From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: bs.x.ttp@recursor.net, git@vger.kernel.org
Subject: Re: [PATCH 4/4] ident: do not ignore empty config name/email
Date: Thu, 23 Feb 2017 20:11:11 -0800 [thread overview]
Message-ID: <xmqqlgsw5iu8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170224010823.my4wmdyezjuqajfx@sigill.intra.peff.net> (Jeff King's message of "Thu, 23 Feb 2017 20:08:23 -0500")
Jeff King <peff@peff.net> writes:
> Keep in mind this _only_ affects Git's config variables. So a script
> feeding git via GIT_AUTHOR_NAME, etc, shouldn't change at all with this
> code.
Ah, that changes the equation somewhat ;-)
> So I dunno. I could really go either way on it. Feel free to drop it, or
> even move it into a separate topic to be cooked longer.
If it were 5 years ago, it would have been different, but I do not
think cooking it longer in 'next' would smoke out breakages in
obscure scripts any longer. Git is used by too many people who have
never seen its source these days.
next prev parent reply other threads:[~2017-02-24 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 4:13 possible bug: inconsistent CLI behaviour for empty user.name bs.x.ttp
2017-02-23 8:11 ` Jeff King
2017-02-23 8:12 ` [PATCH 1/4] ident: mark error messages for translation Jeff King
2017-02-23 8:13 ` [PATCH 2/4] ident: handle NULL email when complaining of empty name Jeff King
2017-02-23 8:15 ` [PATCH 3/4] ident: reject all-crud ident name Jeff King
2017-02-23 8:17 ` [PATCH 4/4] ident: do not ignore empty config name/email Jeff King
2017-02-23 20:58 ` Junio C Hamano
2017-02-24 1:08 ` Jeff King
2017-02-24 4:11 ` Junio C Hamano [this message]
2017-02-24 4:18 ` Jeff King
2017-02-27 15:08 ` Dennis Kaarsemaker
2017-02-27 20:42 ` Junio C Hamano
2017-02-28 5:28 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgsw5iu8.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bs.x.ttp@recursor.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).