From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH v2 1/1] git-clean.txt: clarify ignore pattern files
Date: Thu, 07 Mar 2019 15:56:57 +0900 [thread overview]
Message-ID: <xmqqlg1rmati.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <2eda83517ebad39e14dca9d86b9dc2e0d32e37ef.1551938421.git.liu.denton@gmail.com> (Denton Liu's message of "Wed, 6 Mar 2019 22:05:01 -0800")
Denton Liu <liu.denton@gmail.com> writes:
> -e <pattern>::
> --exclude=<pattern>::
> - In addition to those found in .gitignore (per directory) and
> - $GIT_DIR/info/exclude, also consider these patterns to be in the
> - set of the ignore rules in effect.
> + Use the exclude pattern in addition to those found in
> + `.gitignore` and similar files (see linkgit:gitignore[5]).
>
> -x::
> - Don't use the standard ignore rules read from .gitignore (per
> - directory) and $GIT_DIR/info/exclude, but do still use the ignore
> + Don't use the standard ignore rules read from `.gitignore` and
> + similar files (see linkgit:gitignore[5]), but do still use the ignore
> rules given with `-e` options. This allows removing all untracked
> files, including build products. This can be used (possibly in
> conjunction with 'git reset') to create a pristine
I do agree with the direction to abandon the attempt to be
exhaustive, which has failed us and will fail. I am not sure if
".gitignore and similar files" is a good phrasing, though.
Don't use the standard ignored rules (see linkgit:gitignore[5]),
but use the ignore rules given with `-e` options from the
command line.
perhaps? I dunno.
A related tangent.
"git add --help" also has this bit.
CONFIGURATION
-------------
The optional configuration variable `core.excludesFile` indicates a path to a
file containing patterns of file names to exclude from git-add, similar to
$GIT_DIR/info/exclude. Patterns in the exclude file are used in addition to
those in info/exclude. See linkgit:gitignore[5].
I do not think the omission of per-directory .gitignore from this
description is because the description predates the feature (which
is the reason why "git clean" doc does not mention, by the way), but
this probably needs a simliar treatment.
Or perhaps this configuration section should just be removed (or
moved to gitignore(5)), as it is not specific to "git add".
next prev parent reply other threads:[~2019-03-07 6:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 10:42 [PATCH 0/1] update git-clean.txt Denton Liu
2019-03-06 10:42 ` [PATCH 1/1] git-clean.txt: specify core.excludesFile variable is used Denton Liu
2019-03-06 20:22 ` Martin Ågren
2019-03-07 0:38 ` Junio C Hamano
2019-03-07 6:04 ` [PATCH v2 0/1] make git-clean.txt more precise Denton Liu
2019-03-07 6:05 ` [PATCH v2 1/1] git-clean.txt: clarify ignore pattern files Denton Liu
2019-03-07 6:56 ` Junio C Hamano [this message]
2019-03-07 7:37 ` Martin Ågren
2019-03-07 8:12 ` Junio C Hamano
2019-03-07 8:25 ` [PATCH v3 0/2] consolidate core.excludesFile docs Denton Liu
2019-03-07 8:25 ` [PATCH v3 1/2] git-clean.txt: clarify ignore pattern files Denton Liu
2019-03-07 8:25 ` [PATCH v3 2/2] Docs: move core.excludesFile from git-add to gitignore Denton Liu
2019-03-08 0:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg1rmati.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).