Re: [PATCH 06/10] t5703: adjust a test case for the upcoming default branch name

[Junio C Hamano <gitster@pobox.com>]

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> We want to rename the default branch name used by `git init` in the near
> future, using `main` as the new name.
>
> In preparation for that, we adjust a test case that wants to rename the
> default branch to a different name that however has the same length. We
> use `none` as that name because it matches the length of `main`.

The original chose word that not only is the same length but is
similarly spell (master vs raster).  Perhaps mirroring that
arrangement and picking 'rain' would have been even a better taste,
but this is good enough ;-)

The test pieces in this script seem to be arranged to be mostly
independent from each other, and especially because this one is at
the end of the script, making it run only when 'main' is in use,
and skipping otherwise, would not hurt anybody else.  We just need
to make sure that nobody adds new tests after this one that may be
affected by the allowRefInWant configuration setting.

Looking good.

Thanks.

> -test_expect_success 'server loses a ref - ref in want' '
> +test_expect_success PREPARE_FOR_MAIN_BRANCH 'server loses a ref - ref in want' '
>  	git -C "$REPO" config uploadpack.allowRefInWant true &&
>  	rm -rf local &&
>  	cp -r "$LOCAL_PRISTINE" local &&
> -	echo "s/master/raster/" >"$HTTPD_ROOT_PATH/one-time-perl" &&
> +	echo "s/main/none/" >"$HTTPD_ROOT_PATH/one-time-perl" &&
>  	test_must_fail git -C local fetch 2>err &&
>  
> -	test_i18ngrep "fatal: remote error: unknown ref refs/heads/raster" err
> +	test_i18ngrep "fatal: remote error: unknown ref refs/heads/none" err
>  '
>  
>  # DO NOT add non-httpd-specific tests here, because the last part of this