From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com, emilyshaffer@google.com,
phillip.wood123@gmail.com, Johannes.Schindelin@gmx.de,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] git-rebase.txt: add another hook to the hooks section, and explain more
Date: Fri, 03 Apr 2020 12:35:32 -0700 [thread overview]
Message-ID: <xmqqk12wz7jv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.749.git.git.1585888520572.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Fri, 03 Apr 2020 04:35:20 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> The apply backend has not traditionally called the post-commit hook,
> +while the merge backend has. In contrast, the apply backend has
> +traditionally called the post-checkout hook while the merge backend
> +has not. However, the calling of these hooks in both cases was by
> +accident of implementation rather than by design (both backends were
> +originally implemented as shell scripts and happened to invoke other
> +commands like 'git checkout' or 'git commit' that would call the
> +hooks). Both backends should have the same behavior, though it is not
> +entirely clear which, if any, is correct. We will likely remove both
> +of these hooks in the future.
I'd phrase, instead of "remove", "stop calling from 'git rebase'".
These hooks will still be called from their intended context ;-)
next prev parent reply other threads:[~2020-04-03 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 4:35 [PATCH] git-rebase.txt: add another hook to the hooks section, and explain more Elijah Newren via GitGitGadget
2020-04-03 19:35 ` Junio C Hamano [this message]
2020-04-03 19:52 ` Elijah Newren
2020-04-04 1:30 ` [PATCH v2] " Elijah Newren via GitGitGadget
2020-04-04 9:33 ` Phillip Wood
2020-04-05 0:00 ` [PATCH v3] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk12wz7jv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).