From: Junio C Hamano <gitster@pobox.com>
To: caleb.tillman@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function
Date: Tue, 20 Oct 2020 12:25:58 -0700 [thread overview]
Message-ID: <xmqqimb4bsxl.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201020173257.80525-1-caleb.tillman@gmail.com> (caleb tillman's message of "Tue, 20 Oct 2020 12:32:57 -0500")
caleb.tillman@gmail.com writes:
> From: Caleb Tillman <caleb.tillman@gmail.com>
>
> Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
> ---
Thanks. Let's declare victory and move on. You've demonstrated
through the microproject that you can now comfortably be involved in
the review discussion.
I'll keep the copy I queued on the 20th, though, with this title
t0000: use test_path_is_file instead of "test -f"
which is only slightly longer but is much more descriptive than this
round.
Thanks.
> t/t0000-basic.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 923281af93..eb99892a87 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
> test_expect_success 'git read-tree followed by write-tree should be idempotent' '
> rm -f .git/index &&
> git read-tree $tree &&
> - test -f .git/index &&
> + test_path_is_file .git/index &&
> newtree=$(git write-tree) &&
> test "$newtree" = "$tree"
> '
prev parent reply other threads:[~2020-10-20 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 17:32 [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function caleb.tillman
2020-10-20 19:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimb4bsxl.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=caleb.tillman@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).