From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: Ian Kelling <ian@iankelling.org>, git@vger.kernel.org
Subject: Re: [PATCH v3 2/2] gitweb: use highlight's shebang detection
Date: Sat, 24 Sep 2016 10:52:39 -0700 [thread overview]
Message-ID: <xmqqh995yyl4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <946807ff-1570-2d81-1026-06529164f8ef@gmail.com> ("Jakub Narębski"'s message of "Sat, 24 Sep 2016 18:21:57 +0200")
Jakub Narębski <jnareb@gmail.com> writes:
>> Also, "curling" is not the word I would like to see. I would say:
>>
>> Simple benchmark comparing performance of 'blob' view of files without
>> syntax highlighting in gitweb before and after this change indicates
>> ±1% difference in request time for all file types. Benchmark was
>> performed on local instance on Debian, using Apache/2.4.23 web server
>> and CGI/PSGI/FCGI/mod_perl.
>>
>> ^^^^^^^^^^^^^^^^^^^^^^--- select one
or state that all of them produced similar results ;-)
>> Or something like that; I'm not sure how detailed this should be.
>> But it is nice to have such benchmark in the commit message.
>
> Sidenote: this way of benchmarking of gitweb falls between two ways of
> doing a benchmark.
All good comments. Thanks.
next prev parent reply other threads:[~2016-09-24 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 19:00 [PATCH] gitweb: use highlight's shebang detection Ian Kelling
2016-09-20 20:22 ` Jakub Narębski
2016-09-21 16:38 ` Junio C Hamano
2016-09-21 17:51 ` Jakub Narębski
2016-09-21 22:15 ` Ian Kelling
2016-09-21 22:18 ` Ian Kelling
2016-09-21 22:24 ` Ian Kelling
2016-09-22 22:50 ` [PATCH v2] " Jakub Narębski
2016-09-23 9:08 ` Ian Kelling
2016-09-23 9:08 ` [PATCH v3 1/2] gitweb: remove unused function parameter Ian Kelling
2016-09-23 9:08 ` [PATCH v3 2/2] gitweb: use highlight's shebang detection Ian Kelling
2016-09-23 22:15 ` Jakub Narębski
2016-09-24 16:21 ` Jakub Narębski
2016-09-24 17:52 ` Junio C Hamano [this message]
2016-09-24 22:35 ` Ian Kelling
2016-09-24 22:34 ` Ian Kelling
2016-09-24 22:32 ` [PATCH v4 1/2] gitweb: remove unused guess_file_syntax() parameter Ian Kelling
2016-09-24 22:32 ` [PATCH v4 2/2] gitweb: use highlight's shebang detection Ian Kelling
2016-09-25 18:04 ` Jakub Narębski
2016-09-28 7:37 ` Ian Kelling
2016-09-25 17:57 ` [PATCH v4 1/2] gitweb: remove unused guess_file_syntax() parameter Jakub Narębski
2016-09-23 19:44 ` [PATCH v3 1/2] gitweb: remove unused function parameter Jakub Narębski
2016-09-23 19:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh995yyl4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ian@iankelling.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).