From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 412D620A17 for ; Thu, 19 Jan 2017 18:32:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754112AbdASScf (ORCPT ); Thu, 19 Jan 2017 13:32:35 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:59990 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754032AbdASSce (ORCPT ); Thu, 19 Jan 2017 13:32:34 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B94375E7BA; Thu, 19 Jan 2017 12:58:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=3QWIsCWGTxpqrKUHXJgfGmd5q1M=; b=XxJ7+g 0YBbbkvcE3mcqwy6tTA/2qlYnoJBoxU7oHr0trUUp86P0EI7NNDZ+a25sPPXt2WN mP+qSXBQ/PVwwDaSSvarHEms1CxwBZmc5IUP5BiAna5Yg/qtXLadIdam3ST/QyGP 2A29QxNyDTqqsLa3CH8fNOerdGuS8q++T/u3k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=jIJvpI3aQ20xtRGWZdkauV3qAs7wPdLB +qM367Y56fJvAdLMWEFYjVudGBvBjkDoTYmQhzPxJce8WW7826vnCL1sNWkvmFZi CxUZMqBORzosNP9M3ZIf74XsVq1hbbJo+40+ueJUbTegQuWiZpoQIQSsCX7dYwtQ w25aTUflVg8= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B06CF5E7B9; Thu, 19 Jan 2017 12:58:22 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 0A4725E7B7; Thu, 19 Jan 2017 12:58:21 -0500 (EST) From: Junio C Hamano To: Jacob Keller Cc: Jacob Keller , Git mailing list , Johannes Sixt , Johannes Schindelin Subject: Re: [PATCH v3 1/5] doc: add documentation for OPT_STRING_LIST References: <20170118000930.5431-1-jacob.e.keller@intel.com> <20170118000930.5431-2-jacob.e.keller@intel.com> Date: Thu, 19 Jan 2017 09:58:20 -0800 In-Reply-To: (Jacob Keller's message of "Wed, 18 Jan 2017 13:10:36 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: DDD23E34-DE70-11E6-BAC7-FE3F13518317-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jacob Keller writes: > On Wed, Jan 18, 2017 at 11:45 AM, Junio C Hamano wrote: >> >> I do not know if it is clear enough that 'option' in the last >> sentence is a placeholder. I then wondered if spelling it as >> `--no-` would make it a bit clearer, but that is ugly. > > To be fair, this is exactly how the rest of the doc spells these > things, so I would rather be consistent with the doc as is, and a > future patch could clean this up. See OPT_SET_INT, for an example of > `--no-option`. Ah, OK, then I have no issues with it. > Maybe we can rephrase this "The list is reset via `--no-option`"? I think I saw that in your latest interdiff and I think it is good. Thanks.