From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] handling empty inputs in the revision machinery
Date: Wed, 02 Aug 2017 15:35:45 -0700 [thread overview]
Message-ID: <xmqqh8xpr41q.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170802222425.7xkoxniz2xbjlnku@sigill.intra.peff.net> (Jeff King's message of "Wed, 2 Aug 2017 18:24:25 -0400")
Jeff King <peff@peff.net> writes:
> I noticed that:
>
> git log --tags=does-not-exist
>
> will show all of HEAD, which is rather confusing. This fixes it, and
> also hits several other cases that were marked as expect_failure for
> rev-list. There is one case it doesn't handle: --stdin. It's not clear
> to me what the right behavior is there. I'll follow up with more
> discussion.
Naïvely, I would expect that an empty input from --stdin should
still prevent us from defaulting to "HEAD", just like --glob=* and
friends should do. Perhaps there are conter-example scenarios I
haven't thought of..
Thanks.
>
> [1/4]: t6018: flesh out empty input/output rev-list tests
> [2/4]: revision: add rev_input_given flag
> [3/4]: rev-list: don't show usage when we see empty ref patterns
> [4/4]: revision: do not fallback to default when rev_input_given is set
>
> builtin/rev-list.c | 3 ++-
> revision.c | 3 ++-
> revision.h | 7 +++++++
> t/t4202-log.sh | 6 ++++++
> t/t6018-rev-list-glob.sh | 20 +++++++++-----------
> 5 files changed, 26 insertions(+), 13 deletions(-)
>
> -Peff
prev parent reply other threads:[~2017-08-02 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 22:24 [PATCH 0/4] handling empty inputs in the revision machinery Jeff King
2017-08-02 22:24 ` [PATCH 1/4] t6018: flesh out empty input/output rev-list tests Jeff King
2017-08-02 22:25 ` [PATCH 2/4] revision: add rev_input_given flag Jeff King
2017-08-02 22:41 ` Junio C Hamano
2017-08-02 23:11 ` Jeff King
2017-08-02 22:26 ` [PATCH 3/4] rev-list: don't show usage when we see empty ref patterns Jeff King
2017-08-02 22:30 ` [PATCH 4/4] revision: do not fallback to default when rev_input_given is set Jeff King
2017-08-02 22:44 ` Junio C Hamano
2017-08-02 23:22 ` Stefan Beller
2017-08-02 22:34 ` [PATCH DONOTAPPLY 5/4] revision: let --stdin set rev_input_given Jeff King
2017-08-03 15:59 ` Junio C Hamano
2017-08-03 17:00 ` Jeff King
2017-08-02 22:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8xpr41q.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).