From: Junio C Hamano <gitster@pobox.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.de,
newren@gmail.com, peff@peff.net, chriscool@tuxfamily.org,
jnareb@gmail.com
Subject: Re: [RFC][Feature] submodule: teach subcommand 'summary' to give summary for nested submodules
Date: Wed, 18 Mar 2020 12:48:37 -0700 [thread overview]
Message-ID: <xmqqh7ylfnqi.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200318163234.21628-1-shouryashukla.oo@gmail.com> (Shourya Shukla's message of "Wed, 18 Mar 2020 22:02:34 +0530")
Shourya Shukla <shouryashukla.oo@gmail.com> writes:
> I was converting the subcommand 'summary'(of command submodule)
> from shell to C and I realised that the subcommand does not have a
> '--recursive' option in it, meaning it cannot give out summaries
> of nested submodules. My opinion on this is that an option should
> maybe exist for the same.
>
> What are the community's thoughts on this? Should the
> aforementioned option be added? Is there any feasibility of this
> option in this case?
If "git submodule summary --recursive" errors out with today's code,
no sane user would be using it for any useful purpose, so I would
think it is OK to add such a feature.
If it makes a usable UI for large projects that you can only choose
between "include no subsubmodules" (i.e. with --no-recursive) or
"include all sub(sub)*modules" (i.e. with --recursive) is another
matter, though.
next prev parent reply other threads:[~2020-03-18 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:32 RFC][Feature] submodule: teach subcommand 'summary' to give summary for nested submodules Shourya Shukla
2020-03-18 19:48 ` Junio C Hamano [this message]
2020-03-19 17:16 ` Re: RFC][Feature] submodule Shourya Shukla
2020-03-19 21:33 ` Junio C Hamano
2020-03-20 16:08 ` Re: [RFC][Feature] Shourya Shukla
2020-03-24 7:29 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7ylfnqi.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).