From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 83AD01FF40 for ; Wed, 30 Nov 2016 21:39:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758646AbcK3Vjd (ORCPT ); Wed, 30 Nov 2016 16:39:33 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:53981 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754916AbcK3Vjb (ORCPT ); Wed, 30 Nov 2016 16:39:31 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 0131454462; Wed, 30 Nov 2016 16:39:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=cBcxwAcbgpp2il0wTGi4FEsDynU=; b=VCszLE h4L8ovFh7RSyDRu1OCIfuvSMTJsMQs3Y7cd8/c5o4rhCKNEgs8kcwGSwYnT7fMyV YlYYkUiFBXPuIykq2jSXDIkENo9qkkaesk8pq81iUA2F3QCUmuFhc3RkE651Aor6 YMerJ4FCe/bcTrFGFzApumvWqHBtiIjbp3pe8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=DPiM9lfwT+/D6o6f0q0+9mw9zAmU95f4 6DOuznBcn6TFwkU2R1H4dgP4loesdzmt3jAmnYAkhCEZwVdOwQbPrWWfYG//VFru th3gnkE0qz5+sFeF1upwIv5+2TNPf9ONLgHwErgWGM2OOTj3sFZHRe0njr1esTKh tAxkMiS7XFA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id EC4D454461; Wed, 30 Nov 2016 16:39:09 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 654D35445E; Wed, 30 Nov 2016 16:39:09 -0500 (EST) From: Junio C Hamano To: Stefan Beller Cc: Duy Nguyen , Brandon Williams , Git Mailing List , Jonathan Nieder , Jens Lehmann , Heiko Voigt Subject: Re: [PATCHv2 4/4] submodule: add embed-git-dir function References: <20161122192235.6055-1-sbeller@google.com> <20161122192235.6055-5-sbeller@google.com> Date: Wed, 30 Nov 2016 13:39:08 -0800 In-Reply-To: (Stefan Beller's message of "Wed, 30 Nov 2016 13:00:26 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 6D3A8A98-B745-11E6-9337-E98412518317-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Stefan Beller writes: > git relocate-git-dir (--into-workingtree|--into-gitdir) \ I am not sure if you meant this as a submodule-specific subcommand or more general helper. "into-workingtree" suggests to me that it is submodule specific, so I'll base my response on that assumption. Would there ever be a situation where you already have submodule repositories in the right place (according to the more modern practice, to keep them in .git/modules/ of superproject) and want to move them to embed them in worktrees of submodules? I do not think of any. If there is no such situation, I do not think we want a verb that is direction-neutral (e.g. "move" or "relocate") with two options. Rather we would want "git submodule unembed-git-dir" or something like that.