From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee <stolee@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] send-pack: never fetch when checking exclusions
Date: Sat, 12 Oct 2019 09:47:20 +0900 [thread overview]
Message-ID: <xmqqftjyg57r.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191011161504.GB19741@sigill.intra.peff.net> (Jeff King's message of "Fri, 11 Oct 2019 12:15:05 -0400")
Jeff King <peff@peff.net> writes:
> As a general rule (and why I'm raising this issue in reply to Jonathan's
> patch), I think most or all sites that want OBJECT_INFO_QUICK will want
> SKIP_FETCH_OBJECT as well, and vice versa. The reasoning is generally
> the same:
>
> - it's OK to racily have a false negative (we'll still be correct, but
> possibly a little less optimal)
>
> - it's expected and normal to be missing the object, so spending time
> double-checking the pack store wastes measurable time in real-world
> cases
31f5256c ("sha1-file: split OBJECT_INFO_FOR_PREFETCH", 2019-05-28)
separated SKIP_FETCH_OBJECT out of FOR_PREFETCH, the latter of which
was and is SKIP_FETCH and QUICK combined. Use SKIP_FETCH_OBJECT
alone may need to be re-examined and discouraged?
prev parent reply other threads:[~2019-10-12 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:38 [PATCH] send-pack: never fetch when checking exclusions Jonathan Tan
2019-10-08 4:10 ` Junio C Hamano
2019-10-08 18:37 ` [PATCH v2] " Jonathan Tan
2019-10-11 6:12 ` Jeff King
2019-10-11 12:31 ` Derrick Stolee
2019-10-11 16:15 ` Jeff King
2019-10-11 22:08 ` Jonathan Tan
2019-10-17 6:10 ` Jeff King
2019-10-12 0:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftjyg57r.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).