git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, Brian Gernhardt <brian@gernhardtsoftware.com>
Subject: Re: [PATCH] INSTALL: use existing shell scripts as example
Date: Fri, 15 Nov 2019 14:56:15 +0900	[thread overview]
Message-ID: <xmqqftip7ke8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191114173316.9190-1-rybak.a.v@gmail.com> (Andrei Rybak's message of "Thu, 14 Nov 2019 18:33:16 +0100")

Andrei Rybak <rybak.a.v@gmail.com> writes:

> Script git-pull.sh has been removed in commit [1].  Use command
> "request-pull" as an example of a shell script instead.  Recently, many
> of shell script commands have been re-written in C, so tweak the wording
> of the sentence, while we're here.
>
> [1]: b1456605c2 (pull: remove redirection to git-pull.sh, 2015-06-18)
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>  INSTALL | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index c39006e8e7..e3170b3cee 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -116,8 +116,8 @@ Issues of note:
>  
>  	- "ssh" is used to push and pull over the net.
>  
> -	- A POSIX-compliant shell is required to run many scripts needed
> -	  for everyday use (e.g. "bisect", "pull").
> +	- A POSIX-compliant shell is required to run some scripts needed
> +	  for everyday use (e.g. "bisect", "request-pull").

This is not wrong per-se and does improve the section locally (i.e. "pull"
was a bad example of scripts needed for everyday use).

But in the longer term, I am not sure if we want to keep giving
examples in the first place---this sentence will require constant
rewriting.

Admittedly, this "Git is reasonably self-sufficient, but does
depend" section itself is an oddball to list the requirements by the
final product.  We may want to eject the section (not just this
sentence) from INSTALL file altogether, as otherwise, the document
itself is meant for those who build and install git from the source,
and when you are building from the source, you do need a shell
anyway.

Thanks, will queue.




      reply	other threads:[~2019-11-15  5:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 17:33 [PATCH] INSTALL: use existing shell scripts as example Andrei Rybak
2019-11-15  5:56 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftip7ke8.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=rybak.a.v@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).