From: Junio C Hamano <gitster@pobox.com>
To: Kevin Willford <kcwillford@gmail.com>
Cc: git@vger.kernel.org, Kevin Willford <kewillf@microsoft.com>
Subject: Re: [[PATCH v2] 1/4] patch-ids: stop using a hand-rolled hashmap implementation
Date: Fri, 29 Jul 2016 14:29:52 -0700 [thread overview]
Message-ID: <xmqqeg6cm8tr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160729161920.3792-2-kcwillford@gmail.com> (Kevin Willford's message of "Fri, 29 Jul 2016 12:19:17 -0400")
Kevin Willford <kcwillford@gmail.com> writes:
> +static int patch_id_cmp(struct patch_id *a,
> + struct patch_id *b,
> + void *keydata)
> {
> + return hashcmp(a->patch_id, b->patch_id);
> }
>
> int init_patch_ids(struct patch_ids *ids)
> {
> memset(ids, 0, sizeof(*ids));
> diff_setup(&ids->diffopts);
> DIFF_OPT_SET(&ids->diffopts, RECURSIVE);
> diff_setup_done(&ids->diffopts);
> + hashmap_init(&ids->patches, (hashmap_cmp_fn)patch_id_cmp, 256);
> return 0;
> }
This is a tangent, and I do not suggest to change patch 1/4 to flip
the style, but I am not sure if this is a good style, or casting it
the other way around is better from the type-checking point of view,
i.e.
static int cmp_fn(const void *a_, const void *b_, const void *keydata)
{
struct patch_id *a = a_;
struct patch_id *b = b_;
return hashcmp(a->patch_id, b->patch_id);
}
...
hashmap_init(..., cmp_fn, ...);
...
I see many existing calls to hashmap_init() follow this pattern, so
as I said, patch 1/4 is fine as-is.
Thanks.
next prev parent reply other threads:[~2016-07-29 21:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 16:19 [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content Kevin Willford
2016-07-29 16:19 ` [[PATCH v2] 1/4] patch-ids: stop using a hand-rolled hashmap implementation Kevin Willford
2016-07-29 20:47 ` Junio C Hamano
2016-08-01 8:54 ` Johannes Schindelin
2016-08-01 20:04 ` Junio C Hamano
2016-08-01 22:34 ` Eric Wong
2016-08-02 10:30 ` Johannes Schindelin
2016-08-02 17:01 ` Junio C Hamano
2016-08-02 18:04 ` Junio C Hamano
2016-07-29 21:29 ` Junio C Hamano [this message]
2016-07-29 16:19 ` [[PATCH v2] 2/4] patch-ids: replace the seen indicator with a commit pointer Kevin Willford
2016-07-29 21:03 ` Junio C Hamano
2016-07-29 16:19 ` [[PATCH v2] 3/4] patch-ids: add flag to create the diff patch id using header only data Kevin Willford
2016-07-29 16:19 ` [[PATCH v2] 4/4] rebase: avoid computing unnecessary patch IDs Kevin Willford
2016-07-29 21:46 ` Junio C Hamano
2016-08-01 8:58 ` Johannes Schindelin
2016-08-01 20:11 ` Junio C Hamano
2016-08-02 9:50 ` Jakub Narębski
2016-08-02 17:06 ` Junio C Hamano
2016-08-02 10:45 ` Johannes Schindelin
2016-08-02 17:08 ` Junio C Hamano
2016-08-04 3:00 ` Junio C Hamano
2016-08-04 14:21 ` Johannes Schindelin
2016-07-29 20:22 ` [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content Junio C Hamano
2016-08-01 9:01 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeg6cm8tr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kcwillford@gmail.com \
--cc=kewillf@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).