git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matt Rogers <mattr94@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Diff --stat for files that differ only in whitespace
Date: Fri, 31 Jul 2020 13:25:03 -0700	[thread overview]
Message-ID: <xmqqeeor300w.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAOjrSZskJRj+TVV35fEp-Mhd+proVV72rh3vAcVFnNfhRy2ayA@mail.gmail.com> (Matt Rogers's message of "Fri, 31 Jul 2020 15:26:16 -0400")

Matt Rogers <mattr94@gmail.com> writes:

> On Fri, Jul 31, 2020 at 1:41 PM Jeff King <peff@peff.net> wrote:
>>
>> This seemed familiar, so I dug up some prior discussion here:
>>
>>   https://lore.kernel.org/git/1484704915.2096.16.camel@mattmccutchen.net/
>>
>> We didn't come to a resolution there, but there is a patch to play with,
>> and I think nobody was opposed to the notion that with the right
>> code change we could be suppressing these whitespace-only stat lines
>>
>> -Peff
>
>
> I think for now I'm going to feed --numstat into a script like Junio suggested.
> Out of curiosity what would it take to get that patch into git? Is it just a
> matter of someone just verifying it and submitting it?

After re-reading the thread, I think it takes a bit more than just
re-reading and testing, because even the author of the patch said
(and I think I still agree with the assessment) that the patch does
one thing that is not exactly what we want it to do.  So we'd need
to tweak it more to do what we want to do, I would suspect.

  parent reply	other threads:[~2020-07-31 20:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 13:10 Diff --stat for files that differ only in whitespace Matt Rogers
2020-07-31 17:32 ` Junio C Hamano
2020-07-31 17:41 ` Jeff King
2020-07-31 19:26   ` Matt Rogers
2020-07-31 19:48     ` Jeff King
2020-07-31 20:25     ` Junio C Hamano [this message]
2020-07-31 20:43       ` Matt Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeeor300w.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mattr94@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).