From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id F249F1F51E for ; Fri, 30 Sep 2022 21:46:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="gbw//j5h"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232346AbiI3VqW (ORCPT ); Fri, 30 Sep 2022 17:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbiI3VqU (ORCPT ); Fri, 30 Sep 2022 17:46:20 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86DB638A1F for ; Fri, 30 Sep 2022 14:46:19 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C79E4145226; Fri, 30 Sep 2022 17:46:18 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=kj6qgoc68WTs CoMQb5Yf/zotQfymwsCwSKGNbS82mVo=; b=gbw//j5hR8rBcf4cK0Evkd6RapIe A7HzoHB6SlvIhuDDfbqR78G0QkL6pCNCXUcQ6OcFv0U4wGaMFaGbR3/bHWAdpzug /cWT2drO72wcWSN+VvUJnbueHHge3hOCbauz/0Y+MPoaqrI140WyD1awXgWaP0CV nRpGfjZe/ZBpPao= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BE69D145225; Fri, 30 Sep 2022 17:46:18 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 37489145224; Fri, 30 Sep 2022 17:46:18 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Victoria Dye , Taylor Blau , Emily Shaffer , Jonathan Nieder , John Cai , Eric Sunshine Subject: Re: [PATCH v3 17/36] t/helper/test-proc-receive.c: use "", not "..." References: Date: Fri, 30 Sep 2022 14:46:16 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 30 Sep 2022 20:07:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 50ADE66E-4109-11ED-9708-2AEEC5D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > As in a preceding commit use "", not "...", in this > case there is no *.txt version, but let's fix this one too while we're > at it. I do not quite understand why these need to be separate steps. Some may be supposed to have the same description in the code (help text) and in the text (doc source), and among them, some may have both code and text wrong, and some others may have only code wrong, and even some others only text wrong. It appears to me that you are throwing the first one (both wrong) into a single category, and the latter two (only one wrong) into a separate "not consistent" category, which does not make much sense to me. The end result of this step is good. It is just seeing the split is somewhat distracting while reviewing. Thanks. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > t/helper/test-proc-receive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/helper/test-proc-receive.c b/t/helper/test-proc-receive.= c > index cc08506cf0b..a4b305f4947 100644 > --- a/t/helper/test-proc-receive.c > +++ b/t/helper/test-proc-receive.c > @@ -6,7 +6,7 @@ > #include "test-tool.h" > =20 > static const char *proc_receive_usage[] =3D { > - "test-tool proc-receive [...]", > + "test-tool proc-receive []", > NULL > };