From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id CCF2A1F463 for ; Wed, 11 Dec 2019 17:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729942AbfLKReG (ORCPT ); Wed, 11 Dec 2019 12:34:06 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:57504 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727185AbfLKReF (ORCPT ); Wed, 11 Dec 2019 12:34:05 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id BEAB3935F7; Wed, 11 Dec 2019 12:34:03 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=iWO3gAZz/PYC ZXXcEd8Y3Po5lcE=; b=kZH7WN4lITPqP6vkF7VdLqwoEV2VQagFb1MNmAqY1K1X MIQHY7DBJHyZte2wdnjsRSCn9Kfvndh5p1bzqgxurR1a5jnbel8Pi8fAJuPko1UB dqocAOtD17djgXWWTLW1QxtwuCv0kcktDPUXs9UMKBeC/4OhCZbqbD+ZLIG8C3M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=m+Oa/a e8XAXhrwl0M4GuQTOXjySUaRDSA3iBWYcE1l/Kn3sM+MobuDs+XAISawtuk57FNA bkZM1ISHxnhGZECN4MBvkHo0FhAhLQnn9ylh74DamBJm6ECWHA7aXlqwvV7e1zxv BC/Yh5S79m3kYAgzj69cgrjyVIzioV+cxEFEo= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B7081935F6; Wed, 11 Dec 2019 12:34:03 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id D35D9935EE; Wed, 11 Dec 2019 12:34:00 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: SZEDER =?utf-8?Q?G=C3=A1bor?= , =?utf-8?Q?Ren?= =?utf-8?Q?=C3=A9?= Scharfe , Jonathan Tan , git@vger.kernel.org Subject: Re: [PATCH v3 00/14] name-rev: eliminate recursion References: <20191112103821.30265-1-szeder.dev@gmail.com> <20191209115258.9281-1-szeder.dev@gmail.com> Date: Wed, 11 Dec 2019 09:33:58 -0800 In-Reply-To: (Derrick Stolee's message of "Mon, 9 Dec 2019 10:08:53 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 6B1E48A8-1C3C-11EA-A73D-B0405B776F7B-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Derrick Stolee writes: > On 12/9/2019 6:52 AM, SZEDER G=C3=A1bor wrote: >> 'git name-rev' is implemented using a recursive algorithm, and, >> consequently, it can segfault in deep histories (e.g. WebKit), and >> thanks to a test case demonstrating this limitation every test run >> results in a dmesg entry logging the segfaulting git process. >>=20 >> This patch series eliminates the recursion. >>=20 >> Changes since v2: >>=20 >> - Add the new patch 12 to use 'name->tip_name' instead of >> 'tip_name', to make the patch eliminating the recursion a bit even >> easier to follow (only with '--ignore-all-space', though, without >> that option that patch's diff is still mostly gibberish). >> The end result is the still same, see the empty interdiff. > > This new commit makes sense, and I see how it adjusts the context lines > in the patch that follows. This series looks good to me. I've finished eyeballing the patches myself, and they seem to be in a good shape, too. Thanks.