From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>,
Joachim Schmitz <jojo@schmitz-digital.de>,
Matt Kraai <kraai@ftbfs.org>,
"Randall S. Becker" <randall.becker@nexbridge.ca>
Cc: git@vger.kernel.org, Aleksey Kliger <alklig@microsoft.com>
Subject: Re: [PATCH] config.mak.uname: enable OPEN_RETURNS_EINTR for macOS Big Sur
Date: Mon, 01 Mar 2021 15:57:35 -0800 [thread overview]
Message-ID: <xmqqczwimnps.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YDy0C9sRvboGXQ7P@coredump.intra.peff.net> (Jeff King's message of "Mon, 1 Mar 2021 04:29:47 -0500")
Jeff King <peff@peff.net> writes:
> I got another off-list report of the problem. I think we probably want
> to do this on top:
Queued and pushed out.
I wonder if these hits for SA_RESTART in config.mak.uname would be a
good way to guide us.
[6c109904 (Port to HP NonStop, 2012-09-19)]
# Not detected (nor checked for) by './configure'.
# We don't have SA_RESTART on NonStop, unfortunalety.
COMPAT_CFLAGS += -DSA_RESTART=0
[40036bed (Port to QNX, 2012-12-18)]
ifeq ($(uname_S),QNX)
COMPAT_CFLAGS += -DSA_RESTART=0
One caveat is that we do not know if their system headers hide the
real implementation of open(2) behind a C preprocessor macro, in
whcih case OPEN_RETURNS_EINTR wrapper may not work correctly.
> config.mak.uname | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index e22d4b6d67..d204c20a64 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -124,6 +124,9 @@ ifeq ($(uname_S),Darwin)
> ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 && echo 1),1)
> HAVE_GETDELIM = YesPlease
> endif
> + ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 20 && echo 1),1)
> + OPEN_RETURNS_EINTR = UnfortunatelyYes
> + endif
> NO_MEMMEM = YesPlease
> USE_ST_TIMESPEC = YesPlease
> HAVE_DEV_TTY = YesPlease
next prev parent reply other threads:[~2021-03-02 21:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 4:43 [PATCH] wrapper: add workaround for open() returning EINTR Jeff King
2021-02-24 4:46 ` Jeff King
2021-02-24 5:36 ` Junio C Hamano
2021-02-24 18:20 ` Jeff King
2021-02-26 6:14 ` [PATCH v2] Makefile: add OPEN_RETURNS_EINTR knob Jeff King
2021-02-26 22:17 ` Junio C Hamano
2021-03-01 9:29 ` [PATCH] config.mak.uname: enable OPEN_RETURNS_EINTR for macOS Big Sur Jeff King
2021-03-01 17:17 ` Junio C Hamano
2021-03-01 23:57 ` Junio C Hamano [this message]
2021-03-03 13:41 ` Jeff King
2021-03-04 0:47 ` Junio C Hamano
2021-02-24 4:50 ` [PATCH] wrapper: add workaround for open() returning EINTR Taylor Blau
2021-02-24 7:20 ` Johannes Sixt
2021-02-24 18:23 ` Jeff King
2021-02-26 6:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczwimnps.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=alklig@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jojo@schmitz-digital.de \
--cc=kraai@ftbfs.org \
--cc=peff@peff.net \
--cc=randall.becker@nexbridge.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).