From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Brandon Williams <bmwill@google.com>,
Duy Nguyen <pclouds@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCHv2 27/36] attr: convert to new threadsafe API
Date: Fri, 28 Oct 2016 15:25:21 -0700 [thread overview]
Message-ID: <xmqqbmy4xga6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kayzZOXpRgwREahKAAj+W6M-c2m6dYf5gL3RCxE5+5zJw@mail.gmail.com> (Stefan Beller's message of "Fri, 28 Oct 2016 15:08:44 -0700")
Stefan Beller <sbeller@google.com> writes:
> On Fri, Oct 28, 2016 at 3:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Probably this needs to be squashed in, now the MinGW discussion has
>> settled.
>
> I was about to propose this (and resend it non-rebased).
>
> So I do not resend, but rather ask you to squash this patch?
That's OK. I've queued a "SQUASH???" separately for now and if we
need futher changes, you may want to resend, but I can locally
squash before merging it down to 'next' if it turns out that there
is no more changes necessary.
Thanks.
next prev parent reply other threads:[~2016-10-28 22:25 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 18:54 [PATCHv2 00/36] Revamp the attr subsystem! Stefan Beller
2016-10-28 18:54 ` [PATCHv2 01/36] commit.c: use strchrnul() to scan for one line Stefan Beller
2016-10-28 18:54 ` [PATCHv2 02/36] attr.c: " Stefan Beller
2016-10-28 18:54 ` [PATCHv2 03/36] attr.c: update a stale comment on "struct match_attr" Stefan Beller
2016-10-28 18:54 ` [PATCHv2 04/36] attr.c: explain the lack of attr-name syntax check in parse_attr() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 05/36] attr.c: complete a sentence in a comment Stefan Beller
2016-10-28 18:54 ` [PATCHv2 06/36] attr.c: mark where #if DEBUG ends more clearly Stefan Beller
2016-10-28 18:54 ` [PATCHv2 07/36] attr.c: simplify macroexpand_one() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 08/36] attr.c: tighten constness around "git_attr" structure Stefan Beller
2016-10-28 18:54 ` [PATCHv2 09/36] attr.c: plug small leak in parse_attr_line() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 10/36] attr: rename function and struct related to checking attributes Stefan Beller
2016-10-28 18:54 ` [PATCHv2 11/36] attr: (re)introduce git_check_attr() and struct git_attr_check Stefan Beller
2016-10-28 18:54 ` [PATCHv2 12/36] attr: convert git_all_attrs() to use "struct git_attr_check" Stefan Beller
2016-10-28 18:54 ` [PATCHv2 13/36] attr: convert git_check_attrs() callers to use the new API Stefan Beller
2016-10-28 18:54 ` [PATCHv2 14/36] attr: retire git_check_attrs() API Stefan Beller
2016-10-28 18:54 ` [PATCHv2 15/36] attr: add counted string version of git_check_attr() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 16/36] attr: add counted string version of git_attr() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 17/36] attr: expose validity check for attribute names Stefan Beller
2016-10-28 18:54 ` [PATCHv2 18/36] attr: support quoting pathname patterns in C style Stefan Beller
2016-10-28 18:54 ` [PATCHv2 19/36] attr.c: add push_stack() helper Stefan Beller
2016-10-28 18:54 ` [PATCHv2 20/36] attr.c: pass struct git_attr_check down the callchain Stefan Beller
2016-10-28 18:54 ` [PATCHv2 21/36] attr.c: rename a local variable check Stefan Beller
2016-10-28 18:54 ` [PATCHv2 22/36] attr.c: correct ugly hack for git_all_attrs() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 23/36] attr.c: introduce empty_attr_check_elems() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 24/36] attr.c: always pass check[] to collect_some_attrs() Stefan Beller
2016-10-28 18:54 ` [PATCHv2 25/36] attr.c: outline the future plans by heavily commenting Stefan Beller
2016-10-28 18:54 ` [PATCHv2 26/36] attr: make git_check_attr_counted static Stefan Beller
2016-10-28 18:54 ` [PATCHv2 27/36] attr: convert to new threadsafe API Stefan Beller
2016-10-28 22:06 ` Junio C Hamano
2016-10-28 22:08 ` Stefan Beller
2016-10-28 22:25 ` Junio C Hamano [this message]
2016-10-29 7:10 ` Johannes Sixt
2016-10-28 18:54 ` [PATCHv2 28/36] attr: keep attr stack for each check Stefan Beller
2016-10-28 21:35 ` Junio C Hamano
2016-10-28 18:54 ` [PATCHv2 29/36] Documentation: fix a typo Stefan Beller
2016-10-28 18:54 ` [PATCHv2 30/36] pathspec: move long magic parsing out of prefix_pathspec Stefan Beller
2016-10-28 18:54 ` [PATCHv2 31/36] pathspec: move prefix check out of the inner loop Stefan Beller
2016-10-28 18:54 ` [PATCHv2 32/36] pathspec: allow querying for attributes Stefan Beller
2016-11-09 9:57 ` Duy Nguyen
2016-11-09 22:42 ` Stefan Beller
2016-10-28 18:54 ` [PATCHv2 33/36] pathspec: allow escaped query values Stefan Beller
2016-10-28 18:55 ` [PATCHv2 34/36] submodule update: add `--init-default-path` switch Stefan Beller
2016-11-03 17:46 ` [PATCH] SQUASH to: " Stefan Beller
2016-10-28 18:55 ` [PATCHv2 35/36] clone: add --init-submodule=<pathspec> switch Stefan Beller
2016-10-28 18:55 ` [PATCHv2 36/36] completion: clone can initialize specific submodules Stefan Beller
2016-10-28 21:43 ` [PATCHv2 00/36] Revamp the attr subsystem! Junio C Hamano
2016-10-28 22:02 ` Stefan Beller
2016-10-28 23:59 ` Ramsay Jones
2016-11-03 20:47 ` Johannes Sixt
2016-11-03 20:53 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmy4xga6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).