From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id BFC3D1F55B
	for <e@yhbt.net>; Thu,  4 Jun 2020 17:56:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730295AbgFDRzt (ORCPT <rfc822;e@yhbt.net>);
        Thu, 4 Jun 2020 13:55:49 -0400
Received: from pb-smtp21.pobox.com ([173.228.157.53]:60876 "EHLO
        pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730008AbgFDRzt (ORCPT <rfc822;git@vger.kernel.org>);
        Thu, 4 Jun 2020 13:55:49 -0400
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
        by pb-smtp21.pobox.com (Postfix) with ESMTP id D6361C0642;
        Thu,  4 Jun 2020 13:55:48 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=0PQlQwAj8laWZKYKNDTJlsmzzsM=; b=pcyYK7
        CNtHjN6o1AeqameuP95FHYHXaC4WcFRXYwiyLpJnUyqQPUphJ/fFgmJ7WUXJ5q2d
        V1sxhBppP1pnpXpUfjPLe/F11xBrh3bbX/IEuFY5MnFOncNlanGvMz63syRBuuXC
        tjCOB+DbBWN7EqHHrqLB3LVXb9/8BX9dhcPHU=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=kT00YVBquIFMGRixcoe9ekc9xhCGKzV0
        K7xdlcOGxR+a9GF7TBFN2TKuHePMCd6VZRcwJ9qSpjqtKKtWD/fe0rpjz4XJij8p
        7aYUj5Rh6bBGwFyLvWSZC+dNUWMwdddoSyDeT7y9O2g+kH0Hr+EUKfrv+VYlDkKT
        Er1hLuHocc4=
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp21.pobox.com (Postfix) with ESMTP id CFDFAC0641;
        Thu,  4 Jun 2020 13:55:48 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [35.196.173.25])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 2049BC063E;
        Thu,  4 Jun 2020 13:55:46 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Derrick Stolee <stolee@gmail.com>
Cc:     Abhishek Kumar <abhishekkumar8222@gmail.com>, git@vger.kernel.org,
        jnareb@gmail.com
Subject: Re: [GSoC Patch 0/3] Move generation, graph_pos to a slab
References: <20200604072759.19142-1-abhishekkumar8222@gmail.com>
        <b850637d-a7ca-e8f9-5009-657096ea2975@gmail.com>
Date:   Thu, 04 Jun 2020 10:55:44 -0700
In-Reply-To: <b850637d-a7ca-e8f9-5009-657096ea2975@gmail.com> (Derrick
        Stolee's message of "Thu, 4 Jun 2020 10:22:27 -0400")
Message-ID: <xmqqbllypvfj.fsf@gitster.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 9DCFA4EC-A68C-11EA-83F0-8D86F504CC47-77302942!pb-smtp21.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Derrick Stolee <stolee@gmail.com> writes:

> If we have a commit-graph file, then we have graph_pos
> and generation both coming from that file. Perhaps it
> would be better to combine the data into a single slab
> that stores a "struct commit_graph_data" or something?

Excellent.