From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de, jrnieder@gmail.com
Subject: Re: [PATCH 1/3] submodule update: make use of the existing fetch_in_submodule function
Date: Wed, 25 May 2016 15:41:16 -0700 [thread overview]
Message-ID: <xmqqa8jdzroz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160525220006.27138-2-sbeller@google.com> (Stefan Beller's message of "Wed, 25 May 2016 15:00:04 -0700")
Stefan Beller <sbeller@google.com> writes:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> git-submodule.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 5a4dec0..7698102 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -640,7 +640,7 @@ cmd_update()
> if test -z "$nofetch"
> then
> # Fetch remote before determining tracking $sha1
> - (sanitize_submodule_env; cd "$sm_path" && git-fetch) ||
> + fetch_in_submodule "$sm_path" ||
> die "$(eval_gettext "Unable to fetch in submodule path '\$sm_path'")"
> fi
> remote_name=$(sanitize_submodule_env; cd "$sm_path" && get_default_remote)
Makes sense. The main topic does not depend on this change, I hope,
as I think it is OK to queue this separately and have it graduate
before 2.9-rc1.
next prev parent reply other threads:[~2016-05-25 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 22:00 [PATCH 0/3] Submodules: have a depth field in the .gitmodules file Stefan Beller
2016-05-25 22:00 ` [PATCH 1/3] submodule update: make use of the existing fetch_in_submodule function Stefan Beller
2016-05-25 22:41 ` Junio C Hamano [this message]
2016-05-25 22:45 ` Stefan Beller
2016-05-25 22:00 ` [PATCH 2/3] submodule-config: keep `depth` around Stefan Beller
2016-05-25 22:00 ` [PATCH 3/3] submodule update: learn `--recommended-depth` option Stefan Beller
2016-05-25 22:38 ` [PATCH 0/3] Submodules: have a depth field in the .gitmodules file Junio C Hamano
2016-05-25 22:44 ` Stefan Beller
2020-08-02 15:14 ` medoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8jdzroz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).