From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B337A1F4B4 for ; Wed, 30 Sep 2020 22:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730512AbgI3WdJ (ORCPT ); Wed, 30 Sep 2020 18:33:09 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:59207 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbgI3WdI (ORCPT ); Wed, 30 Sep 2020 18:33:08 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 263B1101F1C; Wed, 30 Sep 2020 18:33:05 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=2GpDdQHPURCeVfWchFMcy42a79g=; b=XgTvOi EczSPYl5ff7bTom1CQ/Ic8IL82EuV5xYqR1GzNz+a/PMmRYBze/DYnbdC6wwP7Cs 6ugxfJLAH54pZTCcflbwPTYr4/QvDa+L0e6gIuKLULPQFyg/cslrmWX9QSE4cnNM ktKVaQI+aihvT3oIaEAOh9eJFuf7/JgCLEPuQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=nxdHe2y6Tyz5g6vofCZuoLBq3tICYs6C 9oRefNO9Rp9TB+7+sQURDYPuLAVqMij74nHceWfQaM9nFUEl5/dTEHj1EAzLSULz evjuEOoykeI4LdWltXPykJ7D1qyQNR+RGAXyfX1mTqbUwgcmYVZ2fuZ+xesixR/8 rrbX42/swyo= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 1EE48101F1B; Wed, 30 Sep 2020 18:33:05 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 66259101F19; Wed, 30 Sep 2020 18:33:02 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Nikita Leonov via GitGitGadget , git@vger.kernel.org, Johannes Schindelin , Nikita Leonov Subject: Re: [PATCH v2 2/3] credentials: make line reading Windows compatible References: <20200929003519.GB898702@coredump.intra.peff.net> Date: Wed, 30 Sep 2020 15:33:00 -0700 In-Reply-To: <20200929003519.GB898702@coredump.intra.peff.net> (Jeff King's message of "Mon, 28 Sep 2020 20:35:19 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E68DD7FC-036C-11EB-90BB-843F439F7C89-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > On Mon, Sep 28, 2020 at 01:58:03PM -0700, Junio C Hamano wrote: > >> "Nikita Leonov via GitGitGadget" writes: >> >> > From: Nikita Leonov >> > >> > This commit makes reading process regarding credentials compatible with >> > 'CR/LF' line ending. It makes using git more convenient on systems like >> > Windows. >> >> I can see why this is a good thing for "store" and the two updated >> pieces of the test script demonstrate it very well. >> >> But it is unclear why and how cache-daemon benefits from this change. >> That needs to be justified. > > I suspect it doesn't need touched, because it is internal to git-daemon. > But it does handle CRLF for some lines, because the first patch > modified credential_read(), which the daemon builds on (and which _is_ > user-facing via git-credential). So there's perhaps an argument that > these calls should just be made consistent, even though the only one who > would write them is our matching client. If that is the argument to be > made, I think it would make sense to do so in a separate patch, since > there's no functional change. > > (I'm also slightly puzzled that anybody on Windows would care about > credential-cache, since it require unix sockets. But maybe in a world of > WSL people are actually able to mix the two. I confess I haven't kept up > with the state of things in Windows). True, so some, if not all, parts of these changes start to look more and more like "I change LF to CRLF purely for political correctness, even I know nobody sends CRLF in these cases (or "even I do not know if anybody sends CRLF in these cases", which essentially amounts to the same thing but may be worse)", needless code churns. Sigh.