From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH 0/2] add format specifiers to display trailers
Date: Fri, 18 Nov 2016 15:38:51 -0800 [thread overview]
Message-ID: <xmqq8tsgl5o4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161118230825.20952-1-jacob.e.keller@intel.com> (Jacob Keller's message of "Fri, 18 Nov 2016 15:08:23 -0800")
Jacob Keller <jacob.e.keller@intel.com> writes:
> Git interpret-trailers will not recognize this as a trailer block
> because it doesn't have any standard git tags within it. Would it be ok
> to augment the trailer interpretation to say that if we have over 75%
> trailers in the block that we accept it even if it doesn't have any real
> recognized tags?
I thought the documented way to do this is to configure one of your
custom trailer as such. Jonathan?
> pretty: add %bT format for displaying trailers of a commit message
Are %(...) taken already? In longer term, it would be nice if we
can unify the --pretty formats and for-each-ref formats, so it is
probably better if we avoid adding any new short ones to the former.
We have %s and %b so that we can reconstruct the whole thing by
using both. It is unclear how %bT fits in this picture. I wonder
if we also need another placeholder that expands to the body of the
message without the trailer---otherwise the whole set would become
incoherent, no?
next prev parent reply other threads:[~2016-11-18 23:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 23:08 [PATCH 0/2] add format specifiers to display trailers Jacob Keller
2016-11-18 23:08 ` [PATCH 1/2] pretty: add %bT format for displaying trailers of a commit message Jacob Keller
2016-11-18 23:08 ` [PATCH 2/2] ref-filter: add support to display trailers as part of contents Jacob Keller
2016-11-18 23:38 ` Junio C Hamano [this message]
2016-11-18 23:42 ` [PATCH 0/2] add format specifiers to display trailers Jacob Keller
2016-11-21 17:23 ` Junio C Hamano
2016-11-29 18:43 ` Keller, Jacob E
2016-11-21 20:47 ` [PATCH] doc: mention user-configured trailers Jonathan Tan
2016-11-21 21:22 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-11-19 0:58 [PATCH 0/2] add format specifiers to display trailers Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tsgl5o4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).