From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org, peartben@gmail.com, benpeart@microsoft.com
Subject: Re: [PATCH 1/3] revision: unify {tree,blob}_objects in rev_info
Date: Thu, 02 Mar 2017 10:36:29 -0800 [thread overview]
Message-ID: <xmqq7f47cyqa.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170228215937.yd4juycjf7y3vish@sigill.intra.peff.net> (Jeff King's message of "Tue, 28 Feb 2017 16:59:37 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Feb 28, 2017 at 01:42:44PM -0800, Junio C Hamano wrote:
>
>> Jonathan Tan <jonathantanmy@google.com> writes:
>>
>> > It could be argued that in the future, Git might need to distinguish
>> > tree_objects from blob_objects - in particular, a user might want
>> > rev-list to print the trees but not the blobs.
>>
>> That was exactly why these bits were originally made to "appear
>> independent but in practice nobody sets only one and leaves others
>> off".
>>
>> And it didn't happen in the past 10 years, which tells us that we
>> should take this patch.
>
> I actually have a patch which uses the distinction. It's for
> upload-archive doing reachability checks (which seems rather familiar to
> what's going on here).
OK. Thanks for stopping me ;-)
next prev parent reply other threads:[~2017-03-02 19:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 1:18 [PATCH 0/3] Test fetch-pack's ability to fetch arbitrary blobs Jonathan Tan
2017-02-25 1:18 ` [PATCH 1/3] revision: unify {tree,blob}_objects in rev_info Jonathan Tan
2017-02-28 21:42 ` Junio C Hamano
2017-02-28 21:59 ` Jeff King
2017-03-02 18:36 ` Junio C Hamano [this message]
2017-02-28 22:06 ` Jeff King
2017-02-25 1:18 ` [PATCH 2/3] revision: exclude trees/blobs given commit Jonathan Tan
2017-02-28 21:44 ` Junio C Hamano
2017-02-28 22:12 ` Jeff King
2017-03-02 19:50 ` [PATCH] t/perf: export variable used in other blocks Jonathan Tan
2017-03-03 6:45 ` Jeff King
2017-03-03 7:14 ` [PATCH] t/perf: use $MODERN_GIT for all repo-copying steps Jeff King
2017-03-03 7:36 ` [PATCH] t/perf: add fallback for pre-bin-wrappers versions of git Jeff King
2017-03-03 18:51 ` [PATCH] t/perf: export variable used in other blocks Junio C Hamano
2017-03-03 22:31 ` Jeff King
2017-02-28 23:12 ` [PATCH 2/3] revision: exclude trees/blobs given commit Junio C Hamano
2017-02-25 1:18 ` [PATCH 3/3] upload-pack: compute blob reachability correctly Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f47cyqa.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).