From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>,
Jordi Mas <jmas@softcatala.org>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Not translatable strings in Git
Date: Tue, 09 May 2017 13:31:39 +0900 [thread overview]
Message-ID: <xmqq7f1q4pn8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170509040722.dd2yt4254g3raeev@sigill.intra.peff.net> (Jeff King's message of "Tue, 9 May 2017 00:07:22 -0400")
Jeff King <peff@peff.net> writes:
> I don't think the diffstat summary is marked for translation at all,
> plumbing or not. There's some history there:
>
> http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u
Wow, that's a long thread.
> There was an attempt to re-enable it for local-only commands:
>
> http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/
>
> but nobody seems to have responded (I don't have much of an opinion
> myself).
I still think that the latter is wrong, especially the part that
touches log-tree.c, pp_header(), and other lower level things that
will be read and interpreted by scripts. The change to diff.c about
the diffstat reverts a bugfix made in v1.8.0 timeperiod, it seems.
prev parent reply other threads:[~2017-05-09 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 8:40 Not translatable strings in Git Jordi Mas
2017-05-08 16:49 ` Stefan Beller
2017-05-09 4:07 ` Jeff King
2017-05-09 4:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f1q4pn8.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jmas@softcatala.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).