From: Junio C Hamano <gitster@pobox.com>
To: "HG King via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, HG King <hgmaxwellking@gmail.com>
Subject: Re: [PATCH] fix: added new BANNED_EXPL macro for better error messages, new parameter
Date: Sun, 07 Mar 2021 12:34:57 -0800 [thread overview]
Message-ID: <xmqq7dmi8zym.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.896.git.1614991897210.gitgitgadget@gmail.com> (HG King via GitGitGadget's message of "Sat, 06 Mar 2021 00:51:36 +0000")
"HG King via GitGitGadget" <gitgitgadget@gmail.com> writes:
> #undef strcpy
> -#define strcpy(x,y) BANNED(strcpy)
> +#define strcpy(x,y) BANNED_EXPL(strcpy, buffer_overflow_risk)
That does not help programmers that much (the above does not say
what to use instead, for example), and the mechanism inherently
does not give you sufficient space to give helpful guidance.
Adding a comment around each of these definition may be OK. Upon
seeing foo_is_a_banned_function, somebody new to the codebase would
look for where it is banned, and find the above, so that is a good
place to give guidance.
next prev parent reply other threads:[~2021-03-07 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 0:51 [PATCH] fix: added new BANNED_EXPL macro for better error messages, new parameter HG King via GitGitGadget
2021-03-07 20:34 ` Junio C Hamano [this message]
2021-03-08 18:05 ` Taylor Blau
2021-03-08 18:30 ` Jeff King
2021-03-08 18:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dmi8zym.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hgmaxwellking@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).