From: Junio C Hamano <gitster@pobox.com>
To: "Gumbel\, Matthew K" <matthew.k.gumbel@intel.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git commit results in many lstat()s
Date: Wed, 01 Feb 2017 15:50:50 -0800 [thread overview]
Message-ID: <xmqq60ktmpwl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <DA0A42D68346B1469147552440A645039A9C57D6@ORSMSX115.amr.corp.intel.com> (Matthew K. Gumbel's message of "Wed, 1 Feb 2017 22:26:05 +0000")
"Gumbel, Matthew K" <matthew.k.gumbel@intel.com> writes:
> "Junio C Hamano" <jch2355@gmail.com> writes:
>> There probably are other things that can be optimized.
>
> Yes, I think that when the user passes --only flag to git-commit, then git does not
> need to call refresh_cache() in prepare_index() in builtin/commit.c.
>
> I may experiment with that. Do you see any downside or negative side-effects?
There may be other fallouts, but one that immediately comes to mind
is that it may break pre-commit hook.
When we get "--only", we prepare an temporary index to create the
commit out of, and give it to the pre-commit hook. The hook expects
that the cached stat information is up-to-date, iow, it does not
have to do 'update-index --refresh' before using plumbing commands
like "diff-index" to do its own inspection of the working tree.
next prev parent reply other threads:[~2017-02-01 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 21:45 git commit results in many lstat()s Gumbel, Matthew K
2017-02-01 22:11 ` Junio C Hamano
2017-02-01 22:26 ` Gumbel, Matthew K
2017-02-01 23:50 ` Junio C Hamano [this message]
2017-02-02 0:14 ` Gumbel, Matthew K
2017-02-02 0:25 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60ktmpwl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matthew.k.gumbel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).