From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [RFC] Universal progress option (was Re: [PATCH] clone: use --quiet when stderr is not a terminal)
Date: Sun, 15 Mar 2020 16:59:48 -0700 [thread overview]
Message-ID: <xmqq5zf59nkb.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqk13l9zmf.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Sun, 15 Mar 2020 12:39:20 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> If the parser that kicks in before the commands do their own parsing
> needs to know that much to correctly understand "--progress" anyway,
> wouldn't the same amount of effort would allow us to teach these
> individual commands to understand "--progress" and pass it correctly
> down to the underlying helpers?
>
> So, "git clone --no-progress" that lets checkout progress may be a
> bug worth fixing, but I do not think a global switch is a good way
> forward.
You can sort-of work it around by introducing "--[no-]progress" that
is taken as an option to the "git" command, just like "--[no-]pager"
is, to work around the issue above. But I have a feeling that you
did not like the resulting UI, which is totally backward incompatible
and break users' existing scripts and habits.
The resulting UI built around "git --[no-]progress subcmd" may feel
much nicer, and I suspect that it would be something we would have
picked, if we had today's experience back when we started adding
progress display to individual subcommands.
As long as a clear transition path can be drawn, I do not
necessarily object to such a direction that (1) introduces the
global level "git --[no-]progress $subcmd" option, and (2)
deprecates and eventually removes the "--progress" option at the
subcommand level.
next prev parent reply other threads:[~2020-03-15 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:09 [PATCH] clone: use --quiet when stderr is not a terminal Derrick Stolee via GitGitGadget
2020-03-14 17:10 ` Junio C Hamano
2020-03-15 12:20 ` Derrick Stolee
2020-03-15 13:41 ` [RFC] Universal progress option (was Re: [PATCH] clone: use --quiet when stderr is not a terminal) Derrick Stolee
2020-03-15 19:39 ` Junio C Hamano
2020-03-15 23:59 ` Junio C Hamano [this message]
2020-03-16 0:27 ` Derrick Stolee
2020-03-14 19:16 ` [PATCH] clone: use --quiet when stderr is not a terminal Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zf59nkb.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).