list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Emily Shaffer <>
Cc:, Jonathan Nieder <>,
	"brian m. carlson" <>
Subject: Re: [PATCH] prefix_path: show gitdir if worktree unavailable
Date: Tue, 03 Mar 2020 09:06:51 -0800
Message-ID: <> (raw)
In-Reply-To: <> (Emily Shaffer's message of "Mon, 2 Mar 2020 20:05:06 -0800")

Emily Shaffer <> writes:

> If there is no worktree at present, we can still hint the user about
> Git's current directory by showing them the absolute path to the Git
> directory. Even though the Git directory doesn't make it as easy to
> locate the worktree in question, it can still help a user figure out
> what's going on while developing a script.
> This fixes a segmentation fault introduced in e0020b2f829.
> Signed-off-by: Emily Shaffer <>
> ---
> This patch is built on top of es/outside-repo-errmsg-hints. I think it
> doesn't need to be, since that change is in master, though.
> Sounds like there's a segfault in the wild:

Thanks.  We should protect the fix with a test, no?

>  pathspec.c | 8 ++++++--
>  setup.c    | 8 ++++++--
>  2 files changed, 12 insertions(+), 4 deletions(-)

      reply	other threads:[~2020-03-03 17:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 23:29 [RFC PATCH] prefix_path: show gitdir when arg is outside repo emilyshaffer
2020-02-15  0:02 ` brian m. carlson
2020-02-15  0:46   ` Emily Shaffer
2020-02-15  1:00 ` [RFC PATCH v2] " Emily Shaffer
2020-02-15  2:56   ` brian m. carlson
2020-02-28 19:58   ` Jonathan Nieder
2020-03-03  2:19     ` Emily Shaffer
2020-03-03  4:05     ` [PATCH] prefix_path: show gitdir if worktree unavailable Emily Shaffer
2020-03-03 17:06       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone