From: Junio C Hamano <gitster@pobox.com>
To: Adrian Wijaya <adrianwijaya100@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"
Date: Fri, 20 Mar 2020 11:04:40 -0700 [thread overview]
Message-ID: <xmqq4kuidhs7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200320160723.15190-1-adrianwijaya100@gmail.com> (Adrian Wijaya's message of "Fri, 20 Mar 2020 23:07:23 +0700")
Adrian Wijaya <adrianwijaya100@gmail.com> writes:
> Subject: Re: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"
I thought the suggestion was either "replace with" or "convert
into", but the above looks a bit funny cross between them. I'd
probably go with "replace".
> Convert "test -f" with "test_path_is_file" to give more verbose
> test output on failure.
Likewise, but the first part is already said in the title. So
Subject: t1300: replace "test -f" with "test_path_is_file"
This way, the test will not fail silently, making it easier
to diagnose.
or something like that, perhaps.
> Signed-off-by: Adrian Wijaya <adrianwijaya100@gmail.com>
> ---
> t/t1300-config.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1300-config.sh b/t/t1300-config.sh
> index 97ebfe1f9d..d74554fc09 100755
> --- a/t/t1300-config.sh
> +++ b/t/t1300-config.sh
> @@ -1020,11 +1020,11 @@ test_expect_success SYMLINKS 'symlinked configuration' '
> ln -s notyet myconfig &&
> git config --file=myconfig test.frotz nitfol &&
> test -h myconfig &&
> - test -f notyet &&
> + test_path_is_file notyet &&
> test "z$(git config --file=notyet test.frotz)" = znitfol &&
> git config --file=myconfig test.xyzzy rezrov &&
> test -h myconfig &&
> - test -f notyet &&
> + test_path_is_file notyet &&
> cat >expect <<-\EOF &&
> nitfol
> rezrov
next prev parent reply other threads:[~2020-03-20 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 23:47 [GSOC][PATCH 1/2] t1300: replace "test -f" into "test_path_is_file" Adrian Wijaya
2020-03-19 23:47 ` [GSOC][PATCH 2/2] " Adrian Wijaya
2020-03-20 5:52 ` Jeff King
2020-03-20 15:22 ` adrian wijaya
2020-03-20 15:45 ` [GSOC][PATCH 1/2] " adrian wijaya
2020-03-20 16:07 ` [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file" Adrian Wijaya
2020-03-20 18:04 ` Junio C Hamano [this message]
2020-03-20 18:08 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2020-03-20 15:56 Adrian Wijaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kuidhs7.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=adrianwijaya100@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).