git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mehul Jain <mehul.jain2029@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH 2/2] log: "--no-show-signature" commmand-line option
Date: Mon, 06 Jun 2016 11:50:51 -0700	[thread overview]
Message-ID: <xmqq37oqxib8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160605153933.15231-3-mehul.jain2029@gmail.com> (Mehul Jain's message of "Sun, 5 Jun 2016 21:09:33 +0530")

Mehul Jain <mehul.jain2029@gmail.com> writes:

> If "log.showSignature=true", then there is no way to override it using
> command line switch.
>
> Teach git-log and related commands about "--no-showSignature" command
> line option.

Doesn't that suggest that 1/2 alone will cause users problems?  The
users can by mistake set the configuration variable and there is no
way for them to override it from the command line.

If you swap the order of the two patches, the topic makes more
sense.  I.e.

    [1/2] log: add "--no-show-signature" command line option

makes "git log --show-signature --no-show-signature" to run without
GPG checks, which by itself is a worthy change.  And then

    [2/2] log: add log.showSignature configuration variable

makes revs->show_signature default to the configured value, instead
of always initializing it to false.

  reply	other threads:[~2016-06-06 18:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-05 15:39 [PATCH 0/2] Introduce "log.showSignature" config variable Mehul Jain
2016-06-05 15:39 ` [PATCH 1/2] log: add "log.showsignature" configuration variable Mehul Jain
2016-06-05 15:39 ` [PATCH 2/2] log: "--no-show-signature" commmand-line option Mehul Jain
2016-06-06 18:50   ` Junio C Hamano [this message]
2016-06-08  6:04     ` Mehul Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37oqxib8.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mehul.jain2029@gmail.com \
    --cc=peff@peff.net \
    --cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).