From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 455E61F619 for ; Tue, 25 Feb 2020 16:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730942AbgBYQ5m (ORCPT ); Tue, 25 Feb 2020 11:57:42 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:58598 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbgBYQ5m (ORCPT ); Tue, 25 Feb 2020 11:57:42 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C9D8658DCA; Tue, 25 Feb 2020 11:57:39 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=PystkQ/EixakxCMV6g/EHiCTfkY=; b=Xahnoe IJML4L8lDrZlyt/6OrnZZrisjpW15DbHXTexJW6FE0ROQS71egHdi7QsN1tOG0Su asD8S1h9YpATQzpwo8LBPlecyaQitJURhgtKxAAv/a4ud6wD80/Jz8Kbmrik5ywl uYh6FSASpJY0tk5pYdw006X9QkqV1muMFkG8c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=qRoU61keuvpdBrcnVAlDDJNzf7Mc4WaG eWHtOwsCXwbGxvdppAvJlHE5zaSNK7BDncuV7e4pdRT3jHOQ0SYaAyfFmhCzRunr AYUcEhM7VYpdDT43RRo/qrwYBzSbkV4p48OC7uEhB72LQH0I/cZNP0UeA6EBnyzx p7WZdUeI090= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C0F5E58DC9; Tue, 25 Feb 2020 11:57:39 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 2535258DC8; Tue, 25 Feb 2020 11:57:39 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Son Luong Ngoc Cc: git@vger.kernel.org, Johannes Schindelin , Thomas Gummerer , Paul-Sebastian Ungureanu Subject: Re: Git Rebase: test failing with GIT_TEST_STASH_USE_BUILTIN=false References: <61922A39-13DC-4B17-94FC-7F67DF308347@booking.com> Date: Tue, 25 Feb 2020 08:57:37 -0800 In-Reply-To: <61922A39-13DC-4B17-94FC-7F67DF308347@booking.com> (Son Luong Ngoc's message of "Mon, 24 Feb 2020 09:33:31 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EE1A9C86-57EF-11EA-91CD-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Son Luong Ngoc writes: > I have been trying to build git from source and noticing that some > tests have been failing since 2.25 with the flag > "GIT_TEST_STASH_USE_BUILTIN=false" > > I think in 2.25 t3903.103 started to fail (rebase related) and > current master t3904 may be failing also. > > Is "GIT_TEST_STASH_USE_BUILTIN=false" is still being tested with > or are we totally deprecating this flag? In the longer term, when "git stash" gains new features that did not exist in the original scripted version, tests that observe how these features work would start failing when using the scripted version. I picked some people from "git shortlog --no-merges builtin/stash.c" and placed them on the CC line---perhaps they may know more. It happens that Johannes is also familiar with "rebase", which you said is involved in the test failure, so I'd imagine he would be the best person to ask. Thanks for a report.