From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] Lib-ify functions in builtin.h
Date: Sat, 21 Mar 2020 12:24:24 -0700 [thread overview]
Message-ID: <xmqq36a1a4uv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <cover.1584786523.git.liu.denton@gmail.com> (Denton Liu's message of "Sat, 21 Mar 2020 06:29:21 -0400")
Denton Liu <liu.denton@gmail.com> writes:
> In builtin.h, there exist a couple of functions that are very lib-ish.
> Extract these functions into their own files which should make more
> organizational sense.
"very lib-ish" feels a bit subjective, but I agree that among those
functions that are currently only allowed to be called from a
built-in command (hence, cannot be called from anything in libgit.a
or non-builtin commands like transports), there may be some funtions
that may make sense to be callable by non-builtin users of libgit.a
(e.g. cgit perhaps?).
I do like the direction these patches are taking us to. I just do
not know how best to phrase it, and having trouble coming up with a
non subjective description.
Thanks.
> Denton Liu (2):
> Lib-ify fmt-merge-msg
> Lib-ify prune-packed
>
> Makefile | 2 +
> builtin.h | 16 -
> builtin/fmt-merge-msg.c | 655 +---------------------------------------
> builtin/prune-packed.c | 44 +--
> builtin/prune.c | 1 +
> builtin/repack.c | 1 +
> fmt-merge-msg.c | 653 +++++++++++++++++++++++++++++++++++++++
> fmt-merge-msg.h | 13 +
> prune-packed.c | 43 +++
> prune-packed.h | 9 +
> 10 files changed, 724 insertions(+), 713 deletions(-)
> create mode 100644 fmt-merge-msg.c
> create mode 100644 prune-packed.c
> create mode 100644 prune-packed.h
next prev parent reply other threads:[~2020-03-21 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 10:29 [PATCH 0/2] Lib-ify functions in builtin.h Denton Liu
2020-03-21 10:29 ` [PATCH 1/2] Lib-ify fmt-merge-msg Denton Liu
2020-03-21 10:29 ` [PATCH 2/2] Lib-ify prune-packed Denton Liu
2020-03-21 19:24 ` Junio C Hamano [this message]
2020-03-24 1:07 ` [PATCH v2 0/2] Lib-ify functions in builtin.h Denton Liu
2020-03-24 1:07 ` [PATCH v2 1/2] Lib-ify fmt-merge-msg Denton Liu
2020-03-24 1:07 ` [PATCH v2 2/2] Lib-ify prune-packed Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36a1a4uv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).