From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id DD8471F5AE for ; Wed, 1 Jul 2020 19:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726287AbgGATyo (ORCPT ); Wed, 1 Jul 2020 15:54:44 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:65277 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgGATyo (ORCPT ); Wed, 1 Jul 2020 15:54:44 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 765CCC08C5; Wed, 1 Jul 2020 15:54:42 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kn2IGTdP4r8h/N83t8n9lkneAJk=; b=Xm1EGR +a/7q7GWJXT+MfqCRqS1lVqJastzmVPFy7aSCteTiRELbRtDhSqpur40rYqF4Hmz kGUjoxDENmDB5HLzvqL6XR3ouv02FpO/eaPu1TKhGQkl1gQOnVxWUq8hnXoeDOvA cB0GnpaV+Jn2auUhEsN2JGhw2fxw3sl95DqCk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=lMdgRICpGkNQXgoaxRr4j8SEvh6dHHB+ TJmotkttaBDYoJUnyYo82JsUdE/VFRjyrlOakePryS1kqhxdULNqGYDb5g7ucHY5 1AMqS91VieUebmGWZXUCDrSh86I2Bxo5NIam7GOiuAbnj7mjNiTa2nBTRXKKdPOt jF4sa9Lz1i4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6C698C08C4; Wed, 1 Jul 2020 15:54:42 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id B41ABC08C2; Wed, 1 Jul 2020 15:54:39 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Johannes Schindelin via GitGitGadget , git@vger.kernel.org, don@goodman-wilson.com, stolee@gmail.com, peff@peff.net, sandals@crustytoothpaste.net, Matt Rogers , Eric Sunshine , Taylor Blau , Phillip Wood , Alban Gruin , Johannes Sixt , Denton Liu , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Philippe Blain Subject: Re: [PATCH v4 1/9] fmt-merge-msg: stop treating `master` specially References: <20200629162003.GD20303@danh.dev> <20200630150533.GF20303@danh.dev> Date: Wed, 01 Jul 2020 12:54:38 -0700 In-Reply-To: (Johannes Schindelin's message of "Wed, 1 Jul 2020 12:39:07 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B2ED27A2-BBD4-11EA-A17A-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: >> In _my very opinion_, I don't think it's that critical. >> We allow git merge --edit and git fmt-merge-msg -m. >> ... > > True. > >> If there're a consensus on changing those documentation, >> I won't mind to do that manual work ;) > > I actually agree that it is not _really_ necessary. > >> The test is a different story, since some (or most?) distro enable >> check (or test) phase for their build infrastructure. >> And, we shouldn't break their infrastructures. > > Actually, the hit in t7606 is in the initial _comment_. So I highly doubt > that it would break any build infrastructure to leave it alone. I guess it's settled, then. Thank you to all for being extra careful.