From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Stefan Beller <sbeller@google.com>, Jeff King <peff@peff.net>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Jens Lehmann <Jens.Lehmann@web.de>,
Fredrik Gustafsson <iveqy@iveqy.com>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>
Subject: Re: [PATCH v2 1/3] serialize collection of changed submodules
Date: Wed, 12 Oct 2016 10:18:28 -0700 [thread overview]
Message-ID: <xmqq1szl5vvf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161012130034.GA84247@book.hvoigt.net> (Heiko Voigt's message of "Wed, 12 Oct 2016 15:00:34 +0200")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> Which seems quite extensively long for a static function so how about
> we shorten it a bit and add a comment:
>
> /* lookup or create commit object list for submodule */
> get_commit_objects_for_submodule_path(...
Or you can even lose "get_" and "path", I guess. You are not even
"getting" commits but the array that holds them, so the caller can
use it to "get" one of them or it can even use it to "put" a new
one, no? "get-commit-objects" is a misnomer in that sense. Either
one of
get_submodule_commits_array()
submodule_commits()
perhaps? I dunno.
next prev parent reply other threads:[~2016-10-12 17:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:06 [PATCH v2 0/3] Speedup finding of unpushed submodules Heiko Voigt
2016-10-07 15:06 ` [PATCH v2 1/3] serialize collection of changed submodules Heiko Voigt
2016-10-07 17:59 ` Stefan Beller
2016-10-10 22:43 ` Junio C Hamano
2016-10-12 13:00 ` Heiko Voigt
2016-10-12 17:18 ` Junio C Hamano [this message]
2016-10-13 15:27 ` Heiko Voigt
2016-10-12 13:11 ` Heiko Voigt
2016-10-07 15:06 ` [PATCH v2 2/3] serialize collection of refs that contain submodule changes Heiko Voigt
2016-10-07 18:16 ` Stefan Beller
2016-10-12 13:10 ` Heiko Voigt
2016-10-20 23:00 ` Stefan Beller
2016-10-10 22:48 ` Junio C Hamano
2016-10-07 15:06 ` [PATCH v2 3/3] batch check whether submodule needs pushing into one call Heiko Voigt
2016-10-07 18:30 ` Stefan Beller
2016-10-10 22:56 ` Junio C Hamano
2016-10-12 13:33 ` Heiko Voigt
2016-10-12 17:37 ` Junio C Hamano
2016-10-13 15:59 ` Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1szl5vvf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=iveqy@iveqy.com \
--cc=leandro.lucarella@sociomantic.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).