From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Giuseppe Crinò" <giuscri@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Pratyush Yadav" <me@yadavpratyush.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Bryan Turner" <bturner@atlassian.com>,
"Git Users" <git@vger.kernel.org>
Subject: Re: [BUG] You can't have single quote in your username
Date: Mon, 02 Sep 2019 12:25:37 -0700 [thread overview]
Message-ID: <xmqq1rwyv6tq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190902154732.GD18593@sigill.intra.peff.net> (Jeff King's message of "Mon, 2 Sep 2019 11:47:33 -0400")
Jeff King <peff@peff.net> writes:
> But it still risks losing a case where some code path relies on the crud
> cleanup for odd cases (mismatched delimiters, or interleaved delimiters,
> or non-delimiter crud mixed in with delimiters).
> ...
> So I dunno. There is no patch to be discussed, and I am not volunteering
> to write one. So I think whoever chooses to do so has a lot of control
> over what is proposed. :)
Rather, they can propose what they want, but they have a lot of
tough defending to do on their choice. Lack of potential harm is
much harder to prove than coming up with a single example that
harms.
I'd rather leave the sleeping dog lie, if we need to encourage
people to live in 21st century and step outside US-ASCII to do so,
then do that instead.
next prev parent reply other threads:[~2019-09-02 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 12:32 [BUG] You can't have single quote in your username Giuseppe Crinò
2019-08-22 15:06 ` Pratyush Yadav
2019-08-22 16:24 ` Junio C Hamano
2019-08-23 7:20 ` Giuseppe Crinò
2019-08-23 7:29 ` Michal Suchánek
2019-08-22 16:06 ` René Scharfe
2019-08-22 16:58 ` Bryan Turner
2019-08-22 17:08 ` Emily Shaffer
2019-08-22 18:43 ` Pratyush Yadav
2019-08-23 8:29 ` SZEDER Gábor
2019-08-23 9:35 ` Giuseppe Crinò
2019-08-23 10:15 ` SZEDER Gábor
2019-08-24 17:49 ` Giuseppe Crinò
2019-08-25 8:09 ` Giuseppe Crinò
2019-08-26 19:14 ` Jeff King
2019-08-27 13:51 ` Giuseppe Crino'
2019-08-27 14:33 ` Michal Suchánek
2019-08-28 14:33 ` Giuseppe Crino'
2019-08-28 14:56 ` Jeff King
2019-08-31 13:17 ` Giuseppe Crinò
2019-09-02 15:47 ` Jeff King
2019-09-02 19:25 ` Junio C Hamano [this message]
2019-09-02 19:50 ` Michal Suchánek
2019-09-03 7:51 ` Giuseppe Crinò
2019-09-03 9:03 ` Michal Suchánek
2019-08-23 8:26 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rwyv6tq.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=bturner@atlassian.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=giuscri@gmail.com \
--cc=me@yadavpratyush.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).