git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Bryan Turner <bturner@atlassian.com>,
	Git Users <git@vger.kernel.org>, "peff\@peff.net" <peff@peff.net>
Subject: Re: Split commit graphs and commit-graph read
Date: Mon, 11 Nov 2019 11:09:24 +0900	[thread overview]
Message-ID: <xmqq1rufjh9n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87f16645-6af4-9703-1d0d-eb64728d2849@gmail.com> (Derrick Stolee's message of "Sun, 10 Nov 2019 20:19:20 -0500")

Derrick Stolee <stolee@gmail.com> writes:

> To fix this issue, I would probably go about it by removing the "read"
> subcommand and creating a "test-tool read-commit-graph" for the tests
> that need that output.
>
> If others on-list think that the better thing to do is to update the
> "read" subcommand to provide the same output, but iterate over each
> layer of an incremental commit-graph, then I can do that work instead.

I think moving it to test-tool is a good idea, whether the output
presents a single result that consolidates all layers together, or
allows to name just a single layer and shows its contents.  I do not
have a strong opinion between the two (both sounds usable debugging
aid).

Thanks.


  reply	other threads:[~2019-11-11  2:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 23:41 Split commit graphs and commit-graph read Bryan Turner
2019-11-11  1:19 ` Derrick Stolee
2019-11-11  2:09   ` Junio C Hamano [this message]
2019-11-11  3:29   ` Jeff King
2019-11-12  0:28   ` Bryan Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1rufjh9n.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).