From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A90CF1F45E for ; Fri, 14 Feb 2020 13:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729353AbgBNNxY (ORCPT ); Fri, 14 Feb 2020 08:53:24 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55316 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729294AbgBNNxY (ORCPT ); Fri, 14 Feb 2020 08:53:24 -0500 Received: by mail-wm1-f67.google.com with SMTP id q9so10024161wmj.5 for ; Fri, 14 Feb 2020 05:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:date:subject:fcc:content-transfer-encoding :mime-version:to:cc; bh=xr/NzZG0zkn/fDRazX3ShNG6MqOrdP69/CSGuWOvWAA=; b=G/Ys//QkVE+nC6HzdL/7dPNk7lrg4EyJbLK+74dW7lCWxWq+nWOO9jnvw50YXo8cSQ E0837CFzWt5ctLHnr6RdRYhZR328kGIMmK0M4GzOvh+M7Dr94+1qHACgmlPl0+uc9c5b Ya8jMIXuXXq1kbgTY15QCizyD9Cw0H9vK++hLLzDtcjqG6OPol6oTrgfFwrSZV5t644Y ZLjMMpuxFMD/74tC7TKXiQMD7BLfmXlIWGExBGNGGFi2j3EBYncFAKgBFzlAtfeUPzwD 3xcrbXOlPaC4L7GlJfJdMf9WgcefE7XV3tRz51HvhSmf2YT9+dc1UNyRSIX+wYU80FtL ls5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=xr/NzZG0zkn/fDRazX3ShNG6MqOrdP69/CSGuWOvWAA=; b=WF1k3i/Oyo0RXshCxHOe0UKts6RWwWMq+DbFzyDWF1WWks/myQ8OuhVQQJesO4Z7ex AbzfZEu1y/xATL07SSghSODXUDnL+V8oRS89MIWhL1auAkDmXIqhPo2WiNJ9JEchjsWc M/S8/bO01SPyxrvCWTkc/2GF4ZjwMHvKLhG2hlzNtwn4q8KTJREZNnkhAEEizU3lQM9U nNTDO35rksjzy6EqVCt1aEztYqp4GQEEJstI1aLiKJ9V3+1l4raILCYd01OYaSfGFOVH 2nuGICWo53TZC+X/NSNEIsoM9c77+IDOAm2FsZ1XpO7r+U1paOTjKzN/5Yg8oz9PdSMc RoVQ== X-Gm-Message-State: APjAAAW72Ngd/WsKRW1k1SsZ078Fe7x5paYHxUP7bEpsYhs6NJ2O3o14 SaqBzlBCxSITe4ph5gRd31ZgL87S X-Google-Smtp-Source: APXvYqwIUstV13DM/MhsvDKrKOUZaVt9eKZfEQLArKQmeiuk5JnL7V0BBNZwkL/2j10KAdiuMdURnw== X-Received: by 2002:a1c:5441:: with SMTP id p1mr5051348wmi.161.1581688402662; Fri, 14 Feb 2020 05:53:22 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id b16sm7038544wmj.39.2020.02.14.05.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 05:53:22 -0800 (PST) Message-Id: From: "Johannes Schindelin via GitGitGadget" Date: Fri, 14 Feb 2020 13:53:21 +0000 Subject: [PATCH] t9001, t9116: avoid pipes Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Johannes Schindelin , Johannes Schindelin Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Johannes Schindelin When grepping through the output of a command in the test suite, there is always a chance that something goes wrong, in which case there would not be anything useful to debug. Let's redirect the output into a file instead, and grep that file, so that the log can be inspected easily if the grep fails. Signed-off-by: Johannes Schindelin --- Avoid pipes in git-svn tests This is one more of those patches that convert the pattern a | b to a >file && b" + $patches >out && + grep "In-Reply-To: " out ' test_expect_success $PREREQ 'no in-reply-to and no threading' ' diff --git a/t/t9116-git-svn-log.sh b/t/t9116-git-svn-log.sh index 45773ee560d..0a9f1ef366d 100755 --- a/t/t9116-git-svn-log.sh +++ b/t/t9116-git-svn-log.sh @@ -43,14 +43,18 @@ test_expect_success 'setup repository and import' ' test_expect_success 'run log' " git reset --hard origin/a && - git svn log -r2 origin/trunk | grep ^r2 && - git svn log -r4 origin/trunk | grep ^r4 && - git svn log -r3 | grep ^r3 + git svn log -r2 origin/trunk >out && + grep ^r2 out && + git svn log -r4 origin/trunk >out && + grep ^r4 out && + git svn log -r3 >out && + grep ^r3 out " test_expect_success 'run log against a from trunk' " git reset --hard origin/trunk && - git svn log -r3 origin/a | grep ^r3 + git svn log -r3 origin/a >out && + grep ^r3 out " printf 'r1 \nr2 \nr4 \n' > expected-range-r1-r2-r4 base-commit: d8437c57fa0752716dde2d3747e7c22bf7ce2e41 -- gitgitgadget