From: "George Espinoza via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: George Espinoza <gespinoz2019@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/6] [Outreachy] check-ref-format: parse-options
Date: Thu, 07 Nov 2019 08:09:54 +0000 [thread overview]
Message-ID: <pull.449.git.1573114201.gitgitgadget@gmail.com> (raw)
This command currently handles its own argv so by teaching it to use
parse-options instead we can standardize the way commands handle user input
across the project.
Because OPT_BOOL data structure is being used on --normalize --no-normalize
can now be utilized.
NO_PARSEOPT flag was also removed to update git.c with the conversion of the
structure in this command.
This is Micro-Project #3 that states: Teach a command which currently
handles its own argv how to use parse-options instead..
Helped by: emily shaffer emilyshaffer@google.com [emilyshaffer@google.com]
Helped by: johannes schindelin johannes.schindelin@gmx.de
[johannes.schindelin@gmx.de]
Signed-off-by: george espinoza gespinoz2019@gmail.com
[gespinoz2019@gmail.com]
george espinoza (6):
[Outreachy] merge-ours: include parse-option.h
[Outreachy] check-ref-format: parse-options
This file wasn't supposed to change during my git push for
check-ref-format :(
[Outreachy] check-ref-format: parse options
[Outreachy] check-ref-format: parse-options
[Outreachy] check-ref-format: parse-options
builtin/check-ref-format.c | 47 +++++++++++++++++++-------------------
git.c | 2 +-
2 files changed, 24 insertions(+), 25 deletions(-)
base-commit: efd54442381a2792186abc994060b8f7dd8b834b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-449%2FGeorgecanfly%2Fcheck-ref-format-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-449/Georgecanfly/check-ref-format-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/449
--
gitgitgadget
next reply other threads:[~2019-11-07 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 8:09 George Espinoza via GitGitGadget [this message]
2019-11-07 8:09 ` [PATCH 1/6] [Outreachy] merge-ours: include parse-option.h george espinoza via GitGitGadget
2019-11-07 9:55 ` Junio C Hamano
2019-11-07 8:09 ` [PATCH 2/6] [Outreachy] check-ref-format: parse-options george espinoza via GitGitGadget
2019-11-07 10:25 ` Junio C Hamano
2019-11-09 7:42 ` George Espinoza
2019-11-07 8:09 ` [PATCH 3/6] This file wasn't supposed to change during my git push for check-ref-format :( george espinoza via GitGitGadget
2019-11-07 10:23 ` Junio C Hamano
2019-11-07 8:09 ` [PATCH 4/6] [Outreachy] check-ref-format: parse options george espinoza via GitGitGadget
2019-11-07 8:09 ` [PATCH 5/6] [Outreachy] check-ref-format: parse-options george espinoza via GitGitGadget
2019-11-07 8:10 ` [PATCH 6/6] " george espinoza via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.449.git.1573114201.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=gespinoz2019@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).