From: "William Baker via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: williamtbakeremail@gmail.com, stolee@gmail.com,
jeffhost@microsoft.com, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] multi-pack-index: add --no-progress
Date: Wed, 11 Sep 2019 08:37:14 -0700 (PDT) [thread overview]
Message-ID: <pull.337.git.gitgitgadget@gmail.com> (raw)
Hello Git contributors!
My name is William Baker and I work at Microsoft. Over the past few years
I've worked closely with the Microsoft team contributing to the git
ecosystem and I'm excited to start working with the community.
Derrick Stolee helped me pick out my first task, and it's to add support for
opting out of the multi-pack-index progress output. The progress feature was
introduced in 144d7033 ("multi-pack-index: report progress during 'verify'",
2018-09-13) but it did not include the ability to opt-out. This patch adds
the --[no-]progress option to allow callers control whether progress is
reported.
This path is very similar to Garima Singh's series for progress reporting in
the commit-graph [1].
[1] https://public-inbox.org/git/pull.315.git.gitgitgadget@gmail.com/
I'm looking forward to your review. Thanks! William Baker
William Baker (1):
multi-pack-index: add --no-progress Add --no-progress option to git
multi-pack-index. The progress feature was added in 144d703
("multi-pack-index: report progress during 'verify'", 2018-09-13)
but the ability to opt-out was overlooked.
Documentation/git-multi-pack-index.txt | 6 +++++-
builtin/multi-pack-index.c | 14 +++++++++---
midx.c | 30 +++++++++++++++++---------
midx.h | 6 ++++--
t/t5319-multi-pack-index.sh | 30 ++++++++++++++++++++++++++
5 files changed, 70 insertions(+), 16 deletions(-)
base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-337%2Fwilbaker%2Fmulti-pack-index-progress-toggle-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-337/wilbaker/multi-pack-index-progress-toggle-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/337
--
gitgitgadget
next reply other threads:[~2019-09-11 15:37 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:37 William Baker via GitGitGadget [this message]
2019-09-11 15:37 ` [PATCH 1/1] multi-pack-index: add --no-progress Add --no-progress option to git multi-pack-index. The progress feature was added in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-09-13) but the ability to opt-out was overlooked William Baker via GitGitGadget
2019-09-12 20:17 ` Junio C Hamano
2019-09-13 18:45 ` William Baker
2019-09-13 20:26 ` Junio C Hamano
2019-09-16 19:49 ` William Baker
2019-09-11 20:30 ` [PATCH 0/1] multi-pack-index: add --no-progress Derrick Stolee
2019-09-20 16:53 ` [PATCH v2 0/6] " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 1/6] midx: add MIDX_PROGRESS flag Add the MIDX_PROGRESS flag and update the write|verify|expire|repack functions in midx.h to accept a flags parameter. The MIDX_PROGRESS flag indicates whether the caller of the function would like progress information to be displayed. This patch only changes the method prototypes and does not change the functionality. The functionality change will be handled by a later patch William Baker via GitGitGadget
2019-09-20 20:01 ` Junio C Hamano
2019-09-20 20:16 ` Junio C Hamano
2019-09-21 12:11 ` [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip> SZEDER Gábor
2019-09-23 21:55 ` William Baker
2019-09-28 3:40 ` Junio C Hamano
2019-09-30 17:01 ` William Baker
2019-10-02 5:38 ` Junio C Hamano
2019-10-02 5:43 ` Junio C Hamano
2019-10-02 7:04 ` Junio C Hamano
2019-10-02 15:56 ` William Baker
2019-10-07 17:12 ` SZEDER Gábor
2019-10-07 17:29 ` SZEDER Gábor
2019-10-08 4:30 ` Junio C Hamano
2019-10-08 16:24 ` William Baker
2019-10-09 0:16 ` SZEDER Gábor
2019-10-09 1:32 ` SZEDER Gábor
2019-10-15 20:00 ` William Baker
2019-10-16 2:09 ` Junio C Hamano
2019-10-16 19:48 ` William Baker
2019-10-18 21:35 ` William Baker
2019-09-20 16:53 ` [PATCH v2 2/6] midx: add progress to write_midx_file Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set William Baker via GitGitGadget
2019-09-20 20:10 ` Junio C Hamano
2019-09-23 21:12 ` William Baker
2019-09-28 3:49 ` Junio C Hamano
2019-09-30 16:36 ` William Baker
2019-09-20 16:53 ` [PATCH v2 3/6] midx: add progress to expire_midx_packs Add progress to expire_midx_packs. " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file Update verify_midx_file to only display progress " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack Update midx_repack " William Baker via GitGitGadget
2019-09-20 20:12 ` Junio C Hamano
2019-09-20 16:53 ` [PATCH v2 6/6] multi-pack-index: add [--[no-]progress] option. Add the --[no-]progress option to git multi-pack-index. Pass the MIDX_PROGRESS flag to the subcommand functions when progress should be displayed by multi-pack-index. The progress feature was added to 'verify' in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-09-13) but some subcommands were not updated to display progress, and the ability to opt-out was overlooked William Baker via GitGitGadget
2019-09-20 19:54 ` [PATCH v2 0/6] multi-pack-index: add --no-progress Junio C Hamano
2019-09-20 20:33 ` William Baker
2019-09-20 20:23 ` Philip Oakley
2019-09-20 20:39 ` William Baker
2019-10-03 17:53 ` [PATCH v3 " William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 1/6] midx: add MIDX_PROGRESS flag William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 2/6] midx: add progress to write_midx_file William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 3/6] midx: add progress to expire_midx_packs William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 6/6] multi-pack-index: add [--[no-]progress] option William Baker via GitGitGadget
2019-10-03 22:46 ` [PATCH v3 0/6] multi-pack-index: add --no-progress Junio C Hamano
2019-10-21 18:39 ` [PATCH v4 " William Baker via GitGitGadget
2019-10-21 18:39 ` [PATCH v4 1/6] midx: add MIDX_PROGRESS flag William Baker via GitGitGadget
2019-10-21 18:39 ` [PATCH v4 2/6] midx: add progress to write_midx_file William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 3/6] midx: add progress to expire_midx_packs William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 6/6] multi-pack-index: add [--[no-]progress] option William Baker via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.337.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=stolee@gmail.com \
--cc=williamtbakeremail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).