From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH v2 1/1] fetch: let --jobs=<n> parallelize --multiple, too
Date: Sun, 6 Oct 2019 11:53:54 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1910061151440.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqftk67r6j.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Sun, 6 Oct 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +test_expect_success 'parallel' '
> > + git remote add one ./bogus1 &&
> > + git remote add two ./bogus2 &&
> > +
> > + test_must_fail env GIT_TRACE="$PWD/trace" \
> > + git fetch --jobs=2 --multiple one two 2>err &&
> > + grep "preparing to run up to 2 tasks" trace &&
> > + test_i18ngrep "could not fetch .one.*128" err &&
> > + test_i18ngrep "could not fetch .two.*128" err
> > +'
> > +
> > test_done
>
> Thanks. I think it is much better to prepare these tests like this
> patch does to be broken when phrasing changes---that would give
> feedback and confidence to the person who is changing the message
> and/or the logic to emit the message.
>
> Where does the constant 128 come from, by the way? If it is from errno.h
> then we will soon hear breakage report from NonStop folks, I predict
> ;-)
It comes from `die()`:
-- snip --
static NORETURN void die_builtin(const char *err, va_list params)
{
/*
* We call this trace2 function first and expect it to va_copy 'params'
* before using it (because an 'ap' can only be walked once).
*/
trace2_cmd_error_va(err, params);
vreportf("fatal: ", err, params);
exit(128);
}
-- snap --
Thanks,
Dscho
next prev parent reply other threads:[~2019-10-06 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:53 [PATCH 0/1] fetch --multiple: respect --jobs= Johannes Schindelin via GitGitGadget
2019-10-01 11:53 ` [PATCH 1/1] fetch: let --jobs=<n> parallelize --multiple, too Johannes Schindelin via GitGitGadget
2019-10-04 4:33 ` Junio C Hamano
2019-10-04 22:03 ` Johannes Schindelin
2019-10-05 18:46 ` [PATCH v2 0/1] fetch --multiple: respect --jobs= Johannes Schindelin via GitGitGadget
2019-10-05 18:46 ` [PATCH v2 1/1] fetch: let --jobs=<n> parallelize --multiple, too Johannes Schindelin via GitGitGadget
[not found] ` <xmqqftk67r6j.fsf@gitster-ct.c.googlers.com>
2019-10-06 9:53 ` Johannes Schindelin [this message]
2019-10-07 1:17 ` Junio C Hamano
2019-10-07 10:14 ` Johannes Schindelin
2019-10-07 10:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1910061151440.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).