From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] compat/*.[ch]: remove extern from function declarations using spatch
Date: Mon, 9 Sep 2019 20:58:31 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1909092058020.5377@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190905032317.GA1381@archbookpro.localdomain>
Hi Denton,
On Wed, 4 Sep 2019, Denton Liu wrote:
> On Wed, Sep 04, 2019 at 11:43:06PM +0200, Johannes Schindelin wrote:
> >
> > On Wed, 4 Sep 2019, Denton Liu wrote:
> >
> > > In 554544276a (*.[ch]: remove extern from function declarations using
> > > spatch, 2019-04-29), we removed externs from function declarations using
> > > spatch but we intentionally excluded files under compat/ since some are
> > > directly copied from an upstream and we should avoid churning them so
> > > that manually merging future updates will be simpler.
> > >
> > > In the last commit, we determined the files which taken from an upstream
> > > so we can exclude them and run spatch on the remainder.
> > >
> > > This was the Coccinelle patch used:
> > >
> > > @@
> > > type T;
> > > identifier f;
> > > @@
> > > - extern
> > > T f(...);
> > >
> > > and it was run with:
> > >
> > > $ git ls-files compat/\*\*.{c,h} |
> > > xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
> > > $ git checkout -- \
> > > compat/regex/ \
> > > compat/inet_ntop.c \
> > > compat/inet_pton.c \
> > > compat/nedmalloc/ \
> > > compat/obstack.{c,h} \
> > > compat/poll/
> > >
> > > Coccinelle has some trouble dealing with `__attribute__` and varargs so
> > > we ran the following to ensure that no remaining changes were left
> > > behind:
> > >
> > > $ git ls-files compat/\*\*.{c,h} |
> > > xargs sed -i'' -e 's/^\(\s*\)extern \([^(]*([^*]\)/\1\2/'
> > > $ git checkout -- \
> > > compat/regex/ \
> > > compat/inet_ntop.c \
> > > compat/inet_pton.c \
> > > compat/nedmalloc/ \
> > > compat/obstack.{c,h} \
> > > compat/poll/
> >
> > I wonder whether we want to make this part of the (slightly misnamed)
> > "Static Analysis" job in our CI.
>
> Do you mean running cocci on all of our source files as opposed to just
> the files we compile? These two patches are part of an experimental (and
> unsubmitted) patchset that does exactly that. Seeing that there's
> interest, I'll try to send it in soon.
I look forward to it!
Dscho
prev parent reply other threads:[~2019-09-09 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 11:09 [PATCH 0/2] cleanup compat/ sources using spatch Denton Liu
2019-09-04 11:09 ` [PATCH 1/2] mingw: apply array.cocci rule Denton Liu
2019-09-04 21:41 ` Johannes Schindelin
2019-09-04 23:36 ` Junio C Hamano
2019-09-04 11:09 ` [PATCH 2/2] compat/*.[ch]: remove extern from function declarations using spatch Denton Liu
2019-09-04 21:43 ` Johannes Schindelin
2019-09-05 3:23 ` Denton Liu
2019-09-09 18:58 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1909092058020.5377@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).