From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ananya Krishna Maram <ananyakittu1997@gmail.com>
Cc: christian.couder@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error
Date: Thu, 4 Oct 2018 16:26:19 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1810041624290.73@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20181004113015.GA30901@manohar-ssh>
Hi Ananya,
thank you for taking the time to write this patch!
On Thu, 4 Oct 2018, Ananya Krishna Maram wrote:
> the forward slash character should be escaped with backslash. Fix
> Unescaped forward slash error in Python regex statements.
>
> Signed-off-by: Ananya Krishna Maram<ananyakittu1997@gmail.com>
That explains pretty well what you did, but I wonder why the forward slash
needs to be escaped? I would understand if we enclosed the pattern in
`/<regex>/`, as it is done e.g. in Javascript, but we do not...
Thanks,
Johannes
> ---
> userdiff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/userdiff.c b/userdiff.c
> index f565f6731..f4ff9b9e5 100644
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -123,7 +123,7 @@ PATTERNS("python", "^[ \t]*((class|def)[ \t].*)$",
> /* -- */
> "[a-zA-Z_][a-zA-Z0-9_]*"
> "|[-+0-9.e]+[jJlL]?|0[xX]?[0-9a-fA-F]+[lL]?"
> - "|[-+*/<>%&^|=!]=|//=?|<<=?|>>=?|\\*\\*=?"),
> + "|[-+*\/<>%&^|=!]=|\/\/=?|<<=?|>>=?|\\*\\*=?"),
> /* -- */
> PATTERNS("ruby", "^[ \t]*((class|module|def)[ \t].*)$",
> /* -- */
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2018-10-04 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 11:30 [PATCH] [Outreachy] git/userdiff.c fix regex pattern error Ananya Krishna Maram
2018-10-04 14:26 ` Johannes Schindelin [this message]
2018-10-04 9:35 ` Ananya Krishna Maram
2018-10-04 15:26 ` Johannes Schindelin
2018-10-04 10:39 ` Ananya Krishna Maram
2018-10-04 19:42 ` Johannes Schindelin
2018-10-06 23:41 ` Junio C Hamano
2018-10-12 7:57 ` Johannes Schindelin
2018-10-12 8:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1810041624290.73@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=ananyakittu1997@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).