From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Stefan Beller <sbeller@google.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees
Date: Tue, 24 Apr 2018 20:51:21 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1804242048360.64@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz> (raw)
In-Reply-To: <CAGZ79ka=BLGCCTOw848m0SE9O+ZKhQfiW9RUz99W4=Gdg+7ofQ@mail.gmail.com>
Hi Stefan,
On Mon, 23 Apr 2018, Stefan Beller wrote:
> On Fri, Apr 20, 2018 at 3:21 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > @@ -250,27 +257,38 @@ static void import_object(struct object_id *oid, enum object_type type,
> > - if (strbuf_read(&result, cmd.out, 41) < 0)
> > - die_errno("unable to read from mktree");
> > + if (strbuf_read(&result, cmd.out, 41) < 0) {
> > + close(fd);
> > + close(cmd.out);
> > + return error_errno("unable to read from mktree");
>
> So before the errno is coming directly from strbuf_read,
> which will set errno on error to the desired errno.
> (It will come from an underlying read())
Yes, you are right!
> However close() may fail and clobber errno,
> so I would think we'd need to
>
> if (strbuf_read(&result, cmd.out, 41) < 0) {
> int err = errno; /* close shall not clobber errno */
> close(fd);
> close(cmd.out);
> errno = err;
> return error_errno(...);
> }
I went for the easier route: call error_errno() before close(fd), and then
return -1 after close(cmd.out). Since error_errno() always returns -1, the
result is pretty much the same (I do not think that we want the caller of
import_object() to rely on the errno).
> > - if (fstat(fd, &st) < 0)
> > - die_errno("unable to fstat %s", filename);
> > + if (fstat(fd, &st) < 0) {
> > + close(fd);
> > + return error_errno("unable to fstat %s", filename);
> > + }
>
> Same here?
Yep.
> An alternative would be to do
> ret = error_errno(...)
> close (..)
> return ret;
I even saved one variable ;-)
> > @@ -288,19 +307,23 @@ static int edit_and_replace(const char *object_ref, int force, int raw)
> > struct strbuf ref = STRBUF_INIT;
> >
> > if (get_oid(object_ref, &old_oid) < 0)
> > - die("Not a valid object name: '%s'", object_ref);
> > + return error("Not a valid object name: '%s'", object_ref);
> >
> > type = oid_object_info(&old_oid, NULL);
> > if (type < 0)
> > - die("unable to get object type for %s", oid_to_hex(&old_oid));
> > + return error("unable to get object type for %s",
> > + oid_to_hex(&old_oid));
> >
> > - check_ref_valid(&old_oid, &prev, &ref, force);
> > + if (check_ref_valid(&old_oid, &prev, &ref, force))
> > + return -1;
> > strbuf_release(&ref);
> >
> > - export_object(&old_oid, type, raw, tmpfile);
> > + if (export_object(&old_oid, type, raw, tmpfile))
> > + return -1;
> > if (launch_editor(tmpfile, NULL, NULL) < 0)
> > - die("editing object file failed");
> > - import_object(&new_oid, type, raw, tmpfile);
> > + return error("editing object file failed");
> > + if (import_object(&new_oid, type, raw, tmpfile))
> > + return -1;
> >
> > free(tmpfile);
>
> Do we need to free tmpfile in previous returns?
Oy vey. How many more mistakes can I introduce in one commit...
> > @@ -394,24 +422,29 @@ static int create_graft(int argc, const char **argv, int force)
> > unsigned long size;
> >
> > if (get_oid(old_ref, &old_oid) < 0)
> > - die(_("Not a valid object name: '%s'"), old_ref);
> > - commit = lookup_commit_or_die(&old_oid, old_ref);
> > + return error(_("Not a valid object name: '%s'"), old_ref);
> > + commit = lookup_commit_reference(&old_oid);
> > + if (!commit)
> > + return error(_("could not parse %s"), old_ref);
> >
> > buffer = get_commit_buffer(commit, &size);
> > strbuf_add(&buf, buffer, size);
> > unuse_commit_buffer(commit, buffer);
> >
> > - replace_parents(&buf, argc - 1, &argv[1]);
> > + if (replace_parents(&buf, argc - 1, &argv[1]) < 0)
> > + return -1;
> >
> > if (remove_signature(&buf)) {
> > warning(_("the original commit '%s' has a gpg signature."), old_ref);
> > warning(_("the signature will be removed in the replacement commit!"));
> > }
> >
> > - check_mergetags(commit, argc, argv);
> > + if (check_mergetags(commit, argc, argv))
> > + return -1;
> >
> > if (write_object_file(buf.buf, buf.len, commit_type, &new_oid))
> > - die(_("could not write replacement commit for: '%s'"), old_ref);
> > + return error(_("could not write replacement commit for: '%s'"),
> > + old_ref);
> >
> > strbuf_release(&buf);
>
> Release &buf in the other return cases, too?
Absolutely.
Thank you for helping me improve these patches,
Dscho
next prev parent reply other threads:[~2018-04-24 18:51 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 11:11 [PATCH] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-13 18:22 ` Stefan Beller
2018-04-13 22:35 ` Johannes Schindelin
2018-04-13 22:45 ` Stefan Beller
2018-04-19 8:15 ` Johannes Schindelin
2018-04-13 18:57 ` Eric Sunshine
2018-04-19 8:14 ` Johannes Schindelin
2018-04-19 8:17 ` [PATCH v2 0/7] Deprecate .git/info/grafts Johannes Schindelin
2018-04-19 8:17 ` [PATCH v2 1/7] replace: "libify" create_graft() Johannes Schindelin
2018-04-20 0:25 ` Junio C Hamano
2018-04-20 11:51 ` Jakub Narebski
2018-04-20 15:32 ` Johannes Schindelin
2018-04-19 8:17 ` [PATCH v2 2/7] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-19 10:09 ` Christian Couder
2018-04-20 13:57 ` Johannes Schindelin
2018-04-20 1:05 ` Junio C Hamano
2018-04-20 15:26 ` Johannes Schindelin
2018-04-19 8:18 ` [PATCH v2 3/7] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-20 1:21 ` Junio C Hamano
2018-04-20 15:31 ` Johannes Schindelin
2018-04-19 8:18 ` [PATCH v2 4/7] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-19 8:18 ` [PATCH v2 5/7] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-19 8:19 ` [PATCH v2 6/7] technical/shallow: describe the relationship with replace refs Johannes Schindelin
2018-04-19 8:21 ` [PATCH v2 7/7] technical/shallow: describe why shallow cannot use " Johannes Schindelin
2018-04-20 22:20 ` [PATCH v3 00/11] Deprecate .git/info/grafts Johannes Schindelin
2018-04-20 22:20 ` [PATCH v3 01/11] argv_array: offer to split a string by whitespace Johannes Schindelin
2018-04-20 23:29 ` Stefan Beller
2018-04-21 9:39 ` Johannes Schindelin
2018-04-20 22:21 ` [PATCH v3 02/11] commit: Let the callback of for_each_mergetag return on error Johannes Schindelin
2018-04-20 22:21 ` [PATCH v3 03/11] replace: avoid using die() to indicate a bug Johannes Schindelin
2018-04-20 22:21 ` [PATCH v3 04/11] replace: "libify" create_graft() and callees Johannes Schindelin
2018-04-20 22:22 ` [PATCH v3 05/11] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-20 22:23 ` [PATCH v3 06/11] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-21 6:20 ` SZEDER Gábor
2018-04-21 9:42 ` Johannes Schindelin
2018-04-20 22:24 ` [PATCH v3 07/11] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-20 22:25 ` [PATCH v3 08/11] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-20 22:26 ` [PATCH v3 09/11] technical/shallow: describe the relationship with replace refs Johannes Schindelin
2018-04-22 15:16 ` Philip Oakley
2018-04-24 19:10 ` Johannes Schindelin
2018-04-24 21:34 ` Philip Oakley
2018-04-25 0:40 ` Junio C Hamano
2018-04-25 7:17 ` Johannes Schindelin
2018-04-20 22:26 ` [PATCH v3 10/11] technical/shallow: describe why shallow cannot use " Johannes Schindelin
2018-04-20 22:27 ` [PATCH v3 11/11] Remove obsolete script to convert grafts to " Johannes Schindelin
2018-04-21 9:43 ` [PATCH v4 00/11] Deprecate .git/info/grafts Johannes Schindelin
2018-04-21 9:46 ` [PATCH v4 01/11] argv_array: offer to split a string by whitespace Johannes Schindelin
2018-04-24 1:15 ` Junio C Hamano
2018-04-24 2:38 ` Junio C Hamano
2018-04-21 9:46 ` [PATCH v4 02/11] commit: Let the callback of for_each_mergetag return on error Johannes Schindelin
2018-04-21 9:47 ` [PATCH v4 03/11] replace: avoid using die() to indicate a bug Johannes Schindelin
2018-04-21 9:47 ` [PATCH v4 04/11] replace: "libify" create_graft() and callees Johannes Schindelin
2018-04-23 19:08 ` Stefan Beller
2018-04-24 18:51 ` Johannes Schindelin [this message]
2018-04-24 19:03 ` Stefan Beller
2018-04-25 7:10 ` Johannes Schindelin
2018-04-21 9:48 ` [PATCH v4 05/11] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-22 3:30 ` Eric Sunshine
2018-04-24 19:04 ` Johannes Schindelin
2018-04-21 9:48 ` [PATCH v4 06/11] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-21 9:49 ` [PATCH v4 07/11] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-21 9:49 ` [PATCH v4 08/11] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-21 9:51 ` [PATCH v4 09/11] technical/shallow: describe the relationship with replace refs Johannes Schindelin
2018-04-21 9:56 ` [PATCH v4 10/11] technical/shallow: describe why shallow cannot use " Johannes Schindelin
2018-04-21 9:56 ` [PATCH v4 11/11] Remove obsolete script to convert grafts to " Johannes Schindelin
2018-04-23 19:24 ` [PATCH v4 00/11] Deprecate .git/info/grafts Stefan Beller
2018-04-25 9:53 ` [PATCH v5 " Johannes Schindelin
2018-04-25 9:53 ` [PATCH v5 01/11] argv_array: offer to split a string by whitespace Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 02/11] commit: Let the callback of for_each_mergetag return on error Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 03/11] replace: avoid using die() to indicate a bug Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 04/11] replace: "libify" create_graft() and callees Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 05/11] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 06/11] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 07/11] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 08/11] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 09/11] technical/shallow: stop referring to grafts Johannes Schindelin
2018-04-25 12:25 ` Jakub Narębski
2018-04-26 9:19 ` Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 10/11] technical/shallow: describe why shallow cannot use replace refs Johannes Schindelin
2018-04-25 9:54 ` [PATCH v5 11/11] Remove obsolete script to convert grafts to " Johannes Schindelin
2018-04-26 4:10 ` [PATCH v5 00/11] Deprecate .git/info/grafts Junio C Hamano
2018-04-27 21:03 ` Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 " Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 01/11] argv_array: offer to split a string by whitespace Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 02/11] commit: Let the callback of for_each_mergetag return on error Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 03/11] replace: avoid using die() to indicate a bug Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 04/11] replace: "libify" create_graft() and callees Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 05/11] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 06/11] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-28 1:25 ` SZEDER Gábor
2018-04-28 13:07 ` Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 07/11] Deprecate support for .git/info/grafts Johannes Schindelin
2018-04-27 21:39 ` [PATCH v6 08/11] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-27 21:40 ` [PATCH v6 09/11] technical/shallow: stop referring to grafts Johannes Schindelin
2018-04-27 21:40 ` [PATCH v6 10/11] technical/shallow: describe why shallow cannot use replace refs Johannes Schindelin
2018-04-27 21:40 ` [PATCH v6 11/11] Remove obsolete script to convert grafts to " Johannes Schindelin
2018-04-28 9:04 ` Philip Oakley
2018-04-28 13:13 ` Johannes Schindelin
2018-04-28 15:00 ` Stefan Beller
2018-04-28 22:47 ` [Re-send PATCH v7 00/12] Deprecate .git/info/grafts Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 01/12] argv_array: offer to split a string by whitespace Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 02/12] commit: Let the callback of for_each_mergetag return on error Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 03/12] replace: avoid using die() to indicate a bug Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 04/12] replace: "libify" create_graft() and callees Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 05/12] replace: prepare create_graft() for converting graft files wholesale Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 06/12] replace: introduce --convert-graft-file Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 07/12] Add a test for `git replace --convert-graft-file` Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 08/12] Deprecate support for .git/info/grafts Johannes Schindelin
2018-11-27 20:12 ` [PATCH] advice: don't pointlessly suggest --convert-graft-file Ævar Arnfjörð Bjarmason
2018-11-28 6:34 ` Junio C Hamano
2018-11-28 9:03 ` Johannes Schindelin
2018-04-28 22:44 ` [PATCH v7 09/12] filter-branch: stop suggesting to use grafts Johannes Schindelin
2018-04-28 22:45 ` [PATCH v7 10/12] technical/shallow: stop referring to grafts Johannes Schindelin
2018-04-28 22:45 ` [PATCH v7 11/12] technical/shallow: describe why shallow cannot use replace refs Johannes Schindelin
2018-04-28 22:45 ` [PATCH v7 12/12] Remove obsolete script to convert grafts to " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1804242048360.64@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz \
--to=johannes.schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).