From: Victor Engmark <victor@engmark.name>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] userdiff: support Bash
Date: Thu, 22 Oct 2020 11:48:09 +1300 [thread overview]
Message-ID: <f56cff1c617de3fa0ce6ebff106dab629565e1fa.camel@engmark.name> (raw)
In-Reply-To: <a07042af-d16c-1975-c0d1-f22f4fec5827@kdbg.org>
On Wed, 2020-10-21 at 09:07 +0200, Johannes Sixt wrote:
> Am 21.10.20 um 05:00 schrieb Victor Engmark:
> > Uses the default `IFS` characters to define words.
>
> We could do better than this, I think. At a minimum, the equal sign,
> single quote, double quote, parentheses, and braces should also
> delineate words. $(, ${, $((, ((, )), [[, ]], should be words. I
> would
> exclude single brackets because they could only occur in globs, IIRC,
> and they need not be broken into words at brackets. $var should be a
> single word, IMO.
>
> That said, this can be presented as a patch on top of this one.
I can't tell where this word definition is used, and I can't seem to
find any tests for the word regexes for the other languages. Is it used
for word diffs somehow? I'll leave it for now, but if you have some
pointers I could look into that later.
Thank you very much for the comments!
next prev parent reply other threads:[~2020-10-21 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:10 [PATCH] userdiff: support Bash Victor Engmark
2020-10-20 23:39 ` Junio C Hamano
2020-10-21 3:00 ` [PATCH v2] " Victor Engmark
2020-10-21 7:07 ` Johannes Sixt
2020-10-21 18:39 ` Junio C Hamano
2020-10-21 22:48 ` Victor Engmark [this message]
2020-10-21 23:45 ` [PATCH v3] " Victor Engmark
2020-10-22 6:08 ` Johannes Sixt
2020-10-22 17:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f56cff1c617de3fa0ce6ebff106dab629565e1fa.camel@engmark.name \
--to=victor@engmark.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).