From: Alban Gruin <alban.gruin@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
git@vger.kernel.org, Adrian Johnson <ajohnson@redneon.com>,
William Duclot <william.duclot@ensimag.grenoble-inp.fr>,
Johannes Sixt <j6t@kdbg.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] userdiff: Add a builtin pattern for dts files
Date: Thu, 17 Jan 2019 22:26:20 +0100 [thread overview]
Message-ID: <e932c7cb-ebf6-1499-00fb-cf0f5e8d9844@gmail.com> (raw)
In-Reply-To: <xmqq7ef7w0kg.fsf@gitster-ct.c.googlers.com>
Hi Junio,
Le 14/01/2019 à 19:34, Junio C Hamano a écrit :
> Alban Gruin <alban.gruin@gmail.com> writes:
>
>> thank you for your patch. I left a few comments below.
>>
>> Le 11/01/2019 à 22:51, Stephen Boyd a écrit:
>>> The Linux kernel receives many patches to the devicetree files each
>>> release. The hunk header for those patches typically show nothing,
>>> making it difficult to figure out what node is being modified without
>>> applying the patch or opening the file and seeking to the context. Let's
>>> add a builtin 'dts' pattern to git so that users can get better diff
>>> output on dts files when they use the diff=dts driver.
>
> A sort of meta-question.
>
> What is missing in the current git that prevents the folks involved
> in device-tree project from achieving what this patch tries to
> accomplish without having to wait the Git project to act on it? To
> put it another way, is it a symptom of a bad design that from time
> to time the Git project has to add built-in patterns?
>
> Ability to ship arbitrary piece of text that you would normally
> place in .git/config is not exactly an answer to the above question,
> and will not happen as that has grave security implications.
>
> But perhaps we can start accepting an in-tree config-like file whose
> contents are limited to verified-safe settings
> (e.g. "diff.*.xfuncname" and nothing else), so that projects can
> ship two files in-tree:
>
> - ".gitattributes" that says "*.dts diff=dts"
>
> - ".gitpreferences" that says "[diff "dts"] xfuncname=..." to
> define the pattern the patch under review adds.
>
> without waiting for the next release of Git to add one more built-in
> pattern?
>
> Anything that defines executable (e.g. "diff.*.command") should
> never be accepted as part of the in-tree config-like file (for two
> reasons: security and portability), but there should be some
> "obviously safe" subset of config settings that we can allow project
> to impose on its users, I hope.
>
I really don’t know what to think about this. I like your proposal, but
it will take some time to write such a feature, while there is a patch
almost ready to support the dts syntax. But I guess that if it is
merged, it will be nearly-impossible to remove from the source if a
feature like you proposed is eventually implemented.
next prev parent reply other threads:[~2019-01-17 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 21:51 [PATCH] userdiff: Add a builtin pattern for dts files Stephen Boyd
2019-01-13 21:26 ` Alban Gruin
2019-01-14 18:34 ` Junio C Hamano
2019-01-17 21:26 ` Alban Gruin [this message]
2019-01-14 18:34 ` Stephen Boyd
2019-01-17 21:26 ` Alban Gruin
2019-01-17 22:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e932c7cb-ebf6-1499-00fb-cf0f5e8d9844@gmail.com \
--to=alban.gruin@gmail.com \
--cc=ajohnson@redneon.com \
--cc=devicetree@vger.kernel.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=william.duclot@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).