From: Ben <ben@wijen.net>
To: phillip.wood@dunelm.org.uk, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Pratik Karki <predatoramigo@gmail.com>
Subject: Re: [PATCH 2/2] rebase.c: make sure current branch isn't moved when autostashing
Date: Tue, 20 Aug 2019 21:53:59 +0200 [thread overview]
Message-ID: <dd1008fc-fdc6-8783-b9db-30a5c7e0a373@wijen.net> (raw)
In-Reply-To: <ff239cf8-f46e-82c5-788a-3484deff51cd@gmail.com>
Hi Phillip,
'git stash create autostash' does not clear the workarea (like 'git stash' does)
That's the reason for the 'git reset --hard'
The difference you see in the test between the legacy rebase and the builtin rebase is because
the legacy 'git reset --hard' emits the 'HEAD is now at ...' which was also included in the builtin rebase
I saw no reason to keep that message as - with my patch - we have concluded the HEAD must not change.
Ben...
On 20-08-2019 11:00, Phillip Wood wrote:
> Hi Ben
>
> I need to have a longer look at this (I don't understand why we're calling reset --hard after we've stashed the changes) but I notice that the test lines you're changing predate the switch to the builtin rebase so those changes are not related to the branch switching problem.
>
> Best Wishes
>
> Phillip
>
> On 18/08/2019 10:53, Ben Wijen wrote:
>> The rebase --autostash incorrectly moved the current branch to orig_head, where
>> orig_head -- commit object name of tip of the branch before rebasing
>>
>> It seems this was incorrectly taken over from git-legacy-rebase.sh
>>
>> Signed-off-by: Ben Wijen <ben@wijen.net>
>> ---
>> builtin/rebase.c | 18 ++++++------------
>> t/t3420-rebase-autostash.sh | 4 ----
>> 2 files changed, 6 insertions(+), 16 deletions(-)
>>
>> diff --git a/builtin/rebase.c b/builtin/rebase.c
>> index 670096c065..a928f44941 100644
>> --- a/builtin/rebase.c
>> +++ b/builtin/rebase.c
>> @@ -1968,9 +1968,6 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
>> state_dir_path("autostash", &options);
>> struct child_process stash = CHILD_PROCESS_INIT;
>> struct object_id oid;
>> - struct commit *head =
>> - lookup_commit_reference(the_repository,
>> - &options.orig_head);
>> argv_array_pushl(&stash.args,
>> "stash", "create", "autostash", NULL);
>> @@ -1991,17 +1988,14 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
>> options.state_dir);
>> write_file(autostash, "%s", oid_to_hex(&oid));
>> printf(_("Created autostash: %s\n"), buf.buf);
>> - if (reset_head(&head->object.oid, "reset --hard",
>> +
>> + /*
>> + * We might not be on orig_head yet:
>> + * Make sure to reset w/o switching branches...
>> + */
>> + if (reset_head(NULL, "reset --hard",
>> NULL, RESET_HEAD_HARD, NULL, NULL) < 0)
>> die(_("could not reset --hard"));
>> - printf(_("HEAD is now at %s"),
>> - find_unique_abbrev(&head->object.oid,
>> - DEFAULT_ABBREV));
>> - strbuf_reset(&buf);
>> - pp_commit_easy(CMIT_FMT_ONELINE, head, &buf);
>> - if (buf.len > 0)
>> - printf(" %s", buf.buf);
>> - putchar('\n');
>> if (discard_index(the_repository->index) < 0 ||
>> repo_read_index(the_repository) < 0)
>> diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh
>> index 867e4e0b17..2ea1909881 100755
>> --- a/t/t3420-rebase-autostash.sh
>> +++ b/t/t3420-rebase-autostash.sh
>> @@ -37,7 +37,6 @@ test_expect_success setup '
>> create_expected_success_am () {
>> cat >expected <<-EOF
>> $(grep "^Created autostash: [0-9a-f][0-9a-f]*\$" actual)
>> - HEAD is now at $(git rev-parse --short feature-branch) third commit
>> First, rewinding head to replay your work on top of it...
>> Applying: second commit
>> Applying: third commit
>> @@ -48,7 +47,6 @@ create_expected_success_am () {
>> create_expected_success_interactive () {
>> q_to_cr >expected <<-EOF
>> $(grep "^Created autostash: [0-9a-f][0-9a-f]*\$" actual)
>> - HEAD is now at $(git rev-parse --short feature-branch) third commit
>> Applied autostash.
>> Successfully rebased and updated refs/heads/rebased-feature-branch.
>> EOF
>> @@ -57,7 +55,6 @@ create_expected_success_interactive () {
>> create_expected_failure_am () {
>> cat >expected <<-EOF
>> $(grep "^Created autostash: [0-9a-f][0-9a-f]*\$" actual)
>> - HEAD is now at $(git rev-parse --short feature-branch) third commit
>> First, rewinding head to replay your work on top of it...
>> Applying: second commit
>> Applying: third commit
>> @@ -70,7 +67,6 @@ create_expected_failure_am () {
>> create_expected_failure_interactive () {
>> cat >expected <<-EOF
>> $(grep "^Created autostash: [0-9a-f][0-9a-f]*\$" actual)
>> - HEAD is now at $(git rev-parse --short feature-branch) third commit
>> Applying autostash resulted in conflicts.
>> Your changes are safe in the stash.
>> You can run "git stash pop" or "git stash drop" at any time.
>>
>
next prev parent reply other threads:[~2019-08-20 19:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 9:53 [PATCH 0/2] git rebase: Make sure upstream branch is left alone Ben Wijen
2019-08-18 9:53 ` [PATCH 1/2] t3420: never change upstream branch Ben Wijen
2019-08-19 21:55 ` Junio C Hamano
2019-08-20 8:58 ` Phillip Wood
2019-08-18 9:53 ` [PATCH 2/2] rebase.c: make sure current branch isn't moved when autostashing Ben Wijen
2019-08-20 9:00 ` Phillip Wood
2019-08-20 19:53 ` Ben [this message]
2019-08-20 20:12 ` [PATCH v2 0/1] git rebase: Make sure upstream branch is left alone Ben Wijen
2019-08-20 20:12 ` [PATCH v2 1/1] rebase.c: make sure current branch isn't moved when autostashing Ben Wijen
2019-08-20 20:24 ` Eric Sunshine
2019-08-20 20:58 ` Junio C Hamano
2019-08-21 18:29 ` [PATCH v3 0/1] rebase.c: make sure the active " Ben Wijen
2019-08-21 18:29 ` [PATCH v3 1/1] " Ben Wijen
2019-08-22 12:27 ` Johannes Schindelin
2019-08-22 15:49 ` Junio C Hamano
2019-08-26 16:45 ` [PATCH v4 " Ben Wijen
2019-08-26 16:45 ` Ben Wijen
2019-08-26 17:10 ` SZEDER Gábor
2019-08-28 12:56 ` Johannes Schindelin
2019-08-28 15:34 ` Junio C Hamano
2019-08-28 16:03 ` Junio C Hamano
2019-08-29 16:47 ` [PATCH v5 0/2] rebase.c: make sure current " Ben Wijen
2019-08-29 16:47 ` [PATCH v5 1/2] builtin/rebase.c: make sure the active " Ben Wijen
2019-08-29 16:47 ` [PATCH v5 2/2] builtin/rebase.c: Remove pointless message Ben Wijen
2019-08-30 15:16 ` [PATCH v6 0/2] rebase.c: make sure current branch isn't moved when autostashing Ben Wijen
2019-08-30 15:16 ` [PATCH v6 1/2] builtin/rebase.c: make sure the active " Ben Wijen
2019-08-30 20:15 ` Junio C Hamano
2019-08-31 7:17 ` Ben
2019-09-01 16:01 ` Junio C Hamano
2019-09-01 16:27 ` Ben
2019-09-02 17:33 ` Junio C Hamano
2019-08-30 15:16 ` [PATCH v6 2/2] builtin/rebase.c: Remove pointless message Ben Wijen
2019-08-30 20:16 ` Junio C Hamano
2019-08-31 7:17 ` Ben
2019-08-30 15:16 ` [PATCH " Ben Wijen
2019-08-19 9:26 ` [PATCH 0/2] git rebase: Make sure upstream branch is left alone Phillip Wood
2019-08-19 15:33 ` Ben
2019-08-19 18:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1008fc-fdc6-8783-b9db-30a5c7e0a373@wijen.net \
--to=ben@wijen.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood@dunelm.org.uk \
--cc=predatoramigo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).