git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Adam Majer <adamm@zombino.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: SHA256 support not experimental, or?
Date: Mon, 31 Jul 2023 15:38:14 +0200	[thread overview]
Message-ID: <d8ba032f-51bc-0bab-fd24-25dea0d56966@zombino.com> (raw)
In-Reply-To: <xmqqr0p230rj.fsf@gitster.g>

On 7/20/23 20:18, Junio C Hamano wrote:
> Adam Majer <adamm@zombino.com> writes:
> 
>>  From 90be51143e741053390810720ba4a639c3b0b74c Mon Sep 17 00:00:00 2001
> 
> Remove all the above lines (including the "From <commit object
> name>").  If you want to add a note that should not be recorded in
> the message of the resulting commit, write it _after_ the three-dash
> line after your sign-off.

Will do. I think the problem was `git format-patch` and then basically 
pasting that inline instead of using it for basis of an email.

I will try again.

> So, the body of the message usually should start from here (below).

+1

> In general, please follow [[describe-changes]] part of the
> Documentation/SubmittingPatches document, and also "git log
> --no-merges" of recent contributions by others.  "The purpose of
> this patch is" is not how we usually talk about our work.

+1

> And the message about SHA-256's non-experimental status can probably
> be a lot stronger, after the discussion we had recently.  How about
> saying something like:
> 
>      Note: there is no interoperability between SHA-256 repositories
>      and SHA-1 repositories right now.  We historically warned that
>      SHA-256 repositories may need backward incompatible changes
>      later when we introduce such interoperability features, but at
>      this point we do not expect that we need to make such a change
>      when we do so, and the users can expect that their SHA-256
>      repositories they create with today's Git will be usable by
>      future versions of Git without losing information.
> 
> which would probably be much closer to what you wanted to hear?

Thanks, I've included additional context now, rebased on top of next 
branch and will attach it as reply to this message.

- Adam

  parent reply	other threads:[~2023-07-31 13:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 16:28 SHA256 support not experimental, or? Adam Majer
2023-06-29  1:59 ` brian m. carlson
2023-06-29 10:42   ` Adam Majer
2023-06-29  5:59 ` Junio C Hamano
2023-06-29 10:53   ` Adam Majer
2023-06-29 20:56     ` Junio C Hamano
2023-06-29 21:17   ` brian m. carlson
2023-06-29 22:22     ` Junio C Hamano
2023-06-30  1:21       ` brian m. carlson
2023-06-30  9:31         ` Patrick Steinhardt
2023-06-30 11:25           ` Adam Majer
2023-06-30 11:38             ` Patrick Steinhardt
2023-06-30 12:20             ` Son Luong Ngoc
2023-06-30 16:45               ` Junio C Hamano
2023-07-20 15:07 ` Adam Majer
2023-07-20 18:18   ` Junio C Hamano
2023-07-26 16:44     ` Junio C Hamano
2023-07-31 13:38     ` Adam Majer [this message]
2023-07-31 13:42       ` [PATCH] doc: sha256 is no longer experimental Adam Majer
2023-07-31 16:01         ` Junio C Hamano
2023-07-31 16:44           ` Adam Majer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8ba032f-51bc-0bab-fd24-25dea0d56966@zombino.com \
    --to=adamm@zombino.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).