git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>
Subject: [PATCH 0/2] More fetch_if_missing=0 removal
Date: Tue, 12 Nov 2019 16:34:18 -0800	[thread overview]
Message-ID: <cover.1573604516.git.jonathantanmy@google.com> (raw)

This is based on jt/fetch-remove-lazy-fetch-plugging.

This patch set both uses the work in commit 6462d5eb9a ("fetch: remove
fetch_if_missing=0", 2019-11-08) and covers up some of the edge use
cases that the aforementioned commit did not cover.

Junio wrote in [1]:

> What I am not certain about is if we are ready
> to move to the right direction for the longer term, or we should still
> be relying on the big-hammer global bit for expediency a bit longer.

I'm not sure if this patch set is an argument for or against. I did
think 6462d5eb9a would be sufficient (but as these patches prove, it was
not), but at the same time, with the additional test coverage provided
by these patches, the overall work might be worth cooking in next.
(Whenever, at $DAY_JOB, we encounter an edge case with partial clone, we
have been submitting patches with test cases for "git fetch" or "git
clone" but sometimes not both, so between 6462d5eb9a and this patch set,
these edge cases would be covered too.)

[1] https://public-inbox.org/git/xmqqh83s8h3m.fsf@gitster-ct.c.googlers.com/

Jonathan Tan (2):
  clone: remove fetch_if_missing=0
  promisor-remote: remove fetch_if_missing=0

 builtin/clone.c   |  3 ---
 connected.c       |  3 ++-
 fetch-pack.c      | 46 ++++++++++++++++++++++++++++++++--------------
 promisor-remote.c |  3 ---
 4 files changed, 34 insertions(+), 21 deletions(-)

-- 
2.24.0.rc1.363.gb1bccd3e3d-goog


             reply	other threads:[~2019-11-13  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  0:34 Jonathan Tan [this message]
2019-11-13  0:34 ` [PATCH 1/2] clone: remove fetch_if_missing=0 Jonathan Tan
2019-11-13  2:50   ` Junio C Hamano
2019-11-13  0:34 ` [PATCH 2/2] promisor-remote: " Jonathan Tan
2019-11-13  2:49 ` [PATCH 0/2] More fetch_if_missing=0 removal Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1573604516.git.jonathantanmy@google.com \
    --to=jonathantanmy@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).