From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH 0/7] Tidy up the constants related to ref_update::flags
Date: Sat, 28 Oct 2017 11:49:49 +0200 [thread overview]
Message-ID: <cover.1509183413.git.mhagger@alum.mit.edu> (raw)
Nothing earth-shattering here; just cleaning up some internal details
that have bothered me for a while:
* Make it clearer which flag values the packed backend might confront.
* Reduce the visibility of the constants that are only relevant to the
files backend. The most notable of these is `REF_ISPRUNING`, which
previously was special-cased in
`REF_TRANSACTION_UPDATE_ALLOWED_FLAGS` even though it shouldn't be
used by callers outside of the refs module.
* Die (rather then silently ignoring) if any disallowed flags are
passed to `ref_transaction_update()` or friends.
* Rename `REF_NODEREF` to `REF_NO_DEREF` (otherwise it's easy to read
as `REF_NODE_REF`!)
* Rename `REF_ISPRUNING` to `REF_IS_PRUNING`.
* Make the constants' numerical values correspond to their order.
* Improve a lot of docstrings.
This patch series depends on `bc/object-id`, mostly so that the
comments can talk about OIDs rather than SHA-1s.
These patches are also available as branch `tidy-ref-update-flags`
from my GitHub fork [1].
Michael
[1] https://github.com/mhagger/git
Michael Haggerty (7):
files_transaction_prepare(): don't leak flags to packed transaction
prune_ref(): call `ref_transaction_add_update()` directly
ref_transaction_update(): die on disallowed flags
ref_transaction_add_update(): remove a check
refs: tidy up and adjust visibility of the `ref_update` flags
refs: rename constant `REF_NODEREF` to `REF_NO_DEREF`
refs: rename constant `REF_ISPRUNING` to `REF_IS_PRUNING`
builtin/am.c | 2 +-
builtin/branch.c | 2 +-
builtin/checkout.c | 2 +-
builtin/clone.c | 4 +-
builtin/notes.c | 2 +-
builtin/remote.c | 6 +--
builtin/symbolic-ref.c | 2 +-
builtin/update-ref.c | 4 +-
refs.c | 6 +--
refs.h | 67 ++++++++++++++++-------------
refs/files-backend.c | 113 +++++++++++++++++++++++++++++++++++++------------
refs/refs-internal.h | 67 +++++++----------------------
sequencer.c | 6 +--
13 files changed, 155 insertions(+), 128 deletions(-)
--
2.14.1
next reply other threads:[~2017-10-28 9:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 9:49 Michael Haggerty [this message]
2017-10-28 9:49 ` [PATCH 1/7] files_transaction_prepare(): don't leak flags to packed transaction Michael Haggerty
2017-10-30 4:44 ` Junio C Hamano
2017-11-05 6:46 ` Michael Haggerty
2017-11-06 1:28 ` Junio C Hamano
2017-10-28 9:49 ` [PATCH 2/7] prune_ref(): call `ref_transaction_add_update()` directly Michael Haggerty
2017-10-28 9:49 ` [PATCH 3/7] ref_transaction_update(): die on disallowed flags Michael Haggerty
2017-10-28 9:49 ` [PATCH 4/7] ref_transaction_add_update(): remove a check Michael Haggerty
2017-10-28 9:49 ` [PATCH 5/7] refs: tidy up and adjust visibility of the `ref_update` flags Michael Haggerty
2017-11-01 8:18 ` Martin Ågren
2017-11-05 7:19 ` Michael Haggerty
2017-10-28 9:49 ` [PATCH 6/7] refs: rename constant `REF_NODEREF` to `REF_NO_DEREF` Michael Haggerty
2017-10-30 4:56 ` Junio C Hamano
2017-10-28 9:49 ` [PATCH 7/7] refs: rename constant `REF_ISPRUNING` to `REF_IS_PRUNING` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1509183413.git.mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).