From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, sbeller@google.com
Subject: [PATCH 0/3] Clarify interaction between signed pushes and push options
Date: Fri, 5 May 2017 16:46:41 -0700 [thread overview]
Message-ID: <cover.1494027001.git.jonathantanmy@google.com> (raw)
We noticed this when trying to use Git to make a signed push with push
options to a server using JGit (which rejects such pushes because the
Git client makes requests that are, strictly speaking, incompatible with
the documented protocol).
There have been several commits (see the commits linked in the commit
messages of the patches sent in reply to this e-mail) to support push
options (that are read by receive hooks) when using "git push", but the
interaction between push options and signed pushes are not very clear.
Here are some patches (containing both code and documentation) that
clarify this interaction.
I would appreciate a review of this - if we could make the protocol
clear, we could then update JGit to use the updated protocol and be no
longer incompatible with existing Git clients.
Jonathan Tan (3):
docs: correct receive.advertisePushOptions default
receive-pack: verify push options in cert
protocol docs: explain receive-pack push options
Documentation/config.txt | 5 ++--
Documentation/git-receive-pack.txt | 10 +++++++
Documentation/technical/pack-protocol.txt | 32 ++++++++++++++++----
builtin/receive-pack.c | 49 ++++++++++++++++++++++++++++---
t/t5534-push-signed.sh | 15 ++++++++++
5 files changed, 98 insertions(+), 13 deletions(-)
--
2.13.0.rc1.294.g07d810a77f-goog
next reply other threads:[~2017-05-05 23:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 23:46 Jonathan Tan [this message]
2017-05-05 23:46 ` [PATCH 1/3] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-05 23:50 ` Brandon Williams
2017-05-05 23:53 ` Stefan Beller
2017-05-05 23:58 ` Jonathan Nieder
2017-05-05 23:46 ` [PATCH 2/3] receive-pack: verify push options in cert Jonathan Tan
2017-05-06 0:02 ` Stefan Beller
2017-05-06 0:06 ` Brandon Williams
2017-05-06 0:20 ` Jonathan Nieder
2017-05-06 0:10 ` Jonathan Nieder
2017-05-05 23:46 ` [PATCH 3/3] protocol docs: explain receive-pack push options Jonathan Tan
2017-05-06 0:10 ` Stefan Beller
2017-05-06 0:26 ` Jonathan Nieder
2017-05-08 21:27 ` Jonathan Tan
2017-05-08 5:44 ` [PATCH 0/3] Clarify interaction between signed pushes and " Junio C Hamano
2017-05-08 21:33 ` [PATCH v2 0/2] " Jonathan Tan
2017-05-08 21:33 ` [PATCH v2 1/2] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-08 21:33 ` [PATCH v2 2/2] receive-pack: verify push options in cert Jonathan Tan
2017-05-09 3:15 ` Junio C Hamano
2017-05-09 3:34 ` Junio C Hamano
2017-05-09 16:45 ` [PATCH] fixup! use perl instead of sed Jonathan Tan
2017-05-09 17:00 ` Ævar Arnfjörð Bjarmason
2017-05-09 19:23 ` [PATCH v3 0/2] Clarify interaction between signed pushes and push options Jonathan Tan
2017-05-09 21:01 ` [PATCH v3] fixup! don't use perl -i because it's not portable Jonathan Tan
2017-05-09 19:23 ` [PATCH v3 1/2] docs: correct receive.advertisePushOptions default Jonathan Tan
2017-05-09 19:23 ` [PATCH v3 2/2] receive-pack: verify push options in cert Jonathan Tan
2017-05-09 20:43 ` [PATCH] fixup! use perl instead of sed Johannes Sixt
2017-05-09 21:04 ` Jonathan Tan
2017-05-09 21:08 ` Ævar Arnfjörð Bjarmason
2017-05-09 22:38 ` Junio C Hamano
2017-05-09 23:44 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1494027001.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).